-
Notifications
You must be signed in to change notification settings - Fork 1.1k
WIP: Convert between CEC and PVsyst single diode models #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cwhanse
wants to merge
20
commits into
pvlib:main
Choose a base branch
from
cwhanse:sdm_convert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0b147e8
functions and tests
cwhanse 480c01b
fix test
cwhanse 22d51ee
build doc pages
cwhanse d65b57f
really fix test
cwhanse bc01aa7
add kwargs
cwhanse ae4346b
docstring edits
cwhanse 1901b20
Merge branch 'main' of https://github.com/pvlib/pvlib-python into sdm…
cwhanse 3dbbefd
Merge branch 'main' of https://github.com/pvlib/pvlib-python into sdm…
cwhanse 30cda13
update to main
cwhanse ef87465
adapt to new organization
cwhanse 5188ee9
paths, names, reference
cwhanse a181438
fixes
cwhanse 3657298
why does cells_in_series have to be special
cwhanse 11ce601
correct IEC61853 matrix, add comments
cwhanse 2bdea49
remake expected test output, add kwargs
cwhanse facdd7e
indents
cwhanse ff20bef
format
cwhanse 92dcb4d
add some print statements to debug test failure
cwhanse 1d4d40c
rtol by parameter
cwhanse 75a55f7
format
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mesh grid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the explicit construction is better, since it omits certain combinations e.g. 100 W/m2 and 75C. The original test construction overlooked this point.