GitHub client: return text by default

Author: ewjoachim

coverage_comment/github_client.py

@@ -83,10 +83,7 @@ def _http(
             **header_kwargs,
             **requests_kwargs,
         )
-        if bytes:
-            contents = response.content
-        else:
-            contents = response_contents(response)
+        contents = response_contents(response=response, bytes=bytes)
 
         try:
             response.raise_for_status()
@@ -103,14 +100,15 @@ def _http(
 
 def response_contents(
     response: httpx.Response,
+    bytes: bool,
 ) -> JsonObject | str | bytes:
+    if bytes:
+        return response.content
+
     if response.headers.get("content-type", "").startswith("application/json"):
         return response.json(object_hook=JsonObject)
-    if response.headers.get("content-type", "").startswith(
-        "application/vnd.github.raw+json"
-    ):
-        return response.text
-    return response.content
+
+    return response.text
 
 
 class JsonObject(dict):

tests/unit/test_github_client.py

@@ -79,4 +79,4 @@ def test_github_client__get_error_non_json(session, gh):
     with pytest.raises(github_client.ApiError) as exc_info:
         gh.repos.get()
 
-    assert str(exc_info.value) == "b'{foobar'"
+    assert str(exc_info.value) == "{foobar"