Updates extract_github_host function + test

Author: daniel-anya

coverage_comment/github.py

@@ -59,29 +59,25 @@ def extract_github_host(api_url: str) -> str:
       The base GitHub web host URL (e.g., 'https://github.com',
       'https://my-ghe.company.com').
     """
-    try:
-        parsed_url = urlparse(api_url)
-        scheme = parsed_url.scheme
-        netloc = parsed_url.netloc  # This includes the domain and potentially the port
-
-        # Special case for GitHub.com API
-        if netloc == "api.github.com":
-            host_domain = "github.com"
-        # Special case for GitHub.com with port (less common but good practice)
-        elif netloc.startswith("api.github.com:"):
-            # Remove 'api.' prefix but keep the port
-            host_domain = netloc.replace("api.", "", 1)
-        # General case for GitHub Enterprise (netloc is already the host:port)
-        else:
-            host_domain = netloc
+    parsed_url = urlparse(api_url)
+    scheme = parsed_url.scheme
+    netloc = parsed_url.netloc  # This includes the domain and potentially the port
+
+    # Special case for GitHub.com API
+    if netloc == "api.github.com":
+        host_domain = "github.com"
+    # Special case for GitHub.com with port (less common but good practice)
+    elif netloc.startswith("api.github.com:"):
+        # Remove 'api.' prefix but keep the port
+        host_domain = netloc.replace("api.", "", 1)
+    # General case for GitHub Enterprise (netloc is already the host:port)
+    else:
+        host_domain = netloc
 
-        # Reconstruct the host URL
-        host_url = f"{scheme}://{host_domain}"
+    # Reconstruct the host URL
+    host_url = f"{scheme}://{host_domain}"
 
-        return host_url
-    except Exception as e:
-        log.error(f"Error parsing URL {api_url}: {e}")
-        return ""
+    return host_url
 
 
 def download_artifact(

tests/integration/test_github.py

@@ -45,6 +45,19 @@ def test_get_repository_info(gh, session):
 
     assert info == github.RepositoryInfo(default_branch="baz", visibility="public")
 
+@pytest.mark.parametrize(
+    "api_url, expected",
+    [
+        ("https://api.github.com/repos/foo/bar", "https://github.com"),
+        ("https://api.github.com:8080/repos/foo/bar", "https://github.com:8080"),
+        ("https://api.github.com/repos/foo/bar/issues", "https://github.com"),
+        ("https://my-ghe.company.com/api/v3/repos/foo/bar", "https://my-ghe.company.com"),
+        ("https://my-ghe.company.com/api/v3/repos/foo/bar/issues", "https://my-ghe.company.com"),
+    ]
+)
+def test_extract_github_host(api_url, expected):
+    result = github.extract_github_host(api_url=api_url)
+    assert result == expected
 
 def test_download_artifact(gh, session, zip_bytes):
     artifacts = [