Refactor setuptools compatibility and add plugin distribution tests #617
+90
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
refactor/setuptools-compat-module
branch
from
265ca7f to
242146c
Compare
bluetech
approved these changes
Oct 27, 2025
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
LGTM. Would make more sense to squash the two commits, no reason to add the test in a separate commit.
BTW I find the commit messages which list all changes to be useless, I'd remove them or rewrite them in human-speak.
RonnyPfannschmidt
force-pushed
the
refactor/setuptools-compat-module
branch
from
242146c to
28fcb7d
Compare
RonnyPfannschmidt
force-pushed
the
refactor/setuptools-compat-module
branch
2 times, most recently
from
bb0a3ee to
c3d4d8d
Compare
Move legacy DistFacade and setuptools compat code to _compat module. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
RonnyPfannschmidt
force-pushed
the
refactor/setuptools-compat-module
branch
from
c3d4d8d to
d011a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor legacy setuptools compatibility code into a dedicated _compat module and add comprehensive tests for the list_plugin_distributions() API.
Depends on #616 - to be merged after.