format

Author: rzabarazesh

torchci/components/metrics/vllm/CiStabilityTrendPanel.tsx

@@ -7,7 +7,7 @@ import {
   getCrosshairTooltipConfig,
   GRID_DEFAULT,
 } from "./chartUtils";
-import { COLOR_SUCCESS, COLOR_ERROR, COLOR_WARNING } from "./constants";
+import { COLOR_ERROR, COLOR_SUCCESS, COLOR_WARNING } from "./constants";
 
 interface TrunkHealthData {
   build_started_at: string;
@@ -33,8 +33,7 @@ function calculateStabilityScore(healthValues: number[]): number {
 
   // Calculate penalties
   const volatilityPenalty = volatility * 50;
-  const transitionPenalty =
-    Math.min(transitions / healthValues.length, 1) * 50;
+  const transitionPenalty = Math.min(transitions / healthValues.length, 1) * 50;
 
   // Return score as percentage (0-1)
   return Math.max(0, 100 - volatilityPenalty - transitionPenalty) / 100;
@@ -51,7 +50,9 @@ function formatTooltip(params: any, stabilityData: any[]): string {
   if (!data) return "";
 
   let result = `<b>${date}</b><br/>`;
-  result += `${params[0].marker} Stability Score: <b>${(data.score * 100).toFixed(1)}%</b><br/>`;
+  result += `${params[0].marker} Stability Score: <b>${(
+    data.score * 100
+  ).toFixed(1)}%</b><br/>`;
   result += `<span style="color: #999; font-size: 0.85em;">`;
   result += `Volatility: ${(data.volatility * 100).toFixed(1)}% | `;
   result += `Transitions: ${data.transitions}`;

torchci/components/metrics/vllm/ContinuousBuildTracker.tsx

@@ -109,13 +109,11 @@ export default function ContinuousBuildTracker({
   // Fetch failed jobs for selected build
   const { data: failedJobsData } = useClickHouseAPIImmutable(
     "vllm/build_failed_jobs",
-    selectedBuildNumber !== null
-      ? {
-          repo: VLLM_REPO_URL,
-          pipelineName: PIPELINE_NAME,
-          buildNumber: selectedBuildNumber,
-        }
-      : null,
+    {
+      repo: VLLM_REPO_URL,
+      pipelineName: PIPELINE_NAME,
+      buildNumber: selectedBuildNumber || 0,
+    },
     selectedBuildNumber !== null
   );
 

torchci/components/metrics/vllm/JobBuildsPanel.tsx

@@ -53,7 +53,12 @@ interface RecentBuildData {
   duration_hours: number | null;
 }
 
-type JobSortField = "job_name" | "total_runs" | "passed_count" | "failed_count";
+type JobSortField =
+  | "job_name"
+  | "total_runs"
+  | "passed_count"
+  | "failed_count"
+  | "last_run_at";
 type SortOrder = "asc" | "desc";
 
 // Helper function to format duration
@@ -117,14 +122,12 @@ export default function JobBuildsPanel({
   // Fetch recent builds for selected job
   const { data: recentBuildsData } = useClickHouseAPIImmutable(
     "vllm/recent_job_builds",
-    selectedJob
-      ? {
-          ...timeParams,
-          repo: VLLM_REPO_URL,
-          pipelineName: PIPELINE_NAME,
-          jobName: selectedJob,
-        }
-      : null,
+    {
+      ...timeParams,
+      repo: VLLM_REPO_URL,
+      pipelineName: PIPELINE_NAME,
+      jobName: selectedJob || "",
+    },
     selectedJob !== null
   );
 

torchci/pages/metrics/vllm.tsx

@@ -17,10 +17,10 @@ import CommitsOnRedTrendPanel from "components/metrics/vllm/CommitsOnRedTrendPan
 import ContinuousBuildTracker from "components/metrics/vllm/ContinuousBuildTracker";
 import DockerBuildRuntimePanel from "components/metrics/vllm/DockerBuildRuntimePanel";
 import DurationDistributionPanel from "components/metrics/vllm/DurationDistributionPanel";
+import JobBuildsPanel from "components/metrics/vllm/JobBuildsPanel";
 import JobGroupFilter, {
   JobGroup,
 } from "components/metrics/vllm/JobGroupFilter";
-import JobBuildsPanel from "components/metrics/vllm/JobBuildsPanel";
 import JobReliabilityPanel from "components/metrics/vllm/JobReliabilityPanel";
 import JobRuntimePanel from "components/metrics/vllm/JobRuntimePanel";
 import MergesPanel from "components/metrics/vllm/MergesPanel";
@@ -604,7 +604,7 @@ export default function Page() {
       ? undefined
       : dailyHealthPercentages.length <= 1
       ? 0
-      : dailyHealthPercentages.reduce((count, current, index) => {
+      : dailyHealthPercentages.reduce((count: number, current, index) => {
           if (index === 0) return 0;
           const previous = dailyHealthPercentages[index - 1];
           return current !== previous ? count + 1 : count;
@@ -620,8 +620,10 @@ export default function Page() {
       : (() => {
           const volatilityPenalty = ciHealthVolatility * 50; // 0-50 penalty
           const transitionPenalty =
-            Math.min(stateTransitions / (dailyHealthPercentages?.length || 1), 1) *
-            50; // 0-50 penalty
+            Math.min(
+              stateTransitions / (dailyHealthPercentages?.length || 1),
+              1
+            ) * 50; // 0-50 penalty
           return Math.max(0, 100 - volatilityPenalty - transitionPenalty) / 100;
         })();
 
@@ -693,7 +695,7 @@ export default function Page() {
       ? undefined
       : prevDailyHealthPercentages.length <= 1
       ? 0
-      : prevDailyHealthPercentages.reduce((count, current, index) => {
+      : prevDailyHealthPercentages.reduce((count: number, current, index) => {
           if (index === 0) return 0;
           const previous = prevDailyHealthPercentages[index - 1];
           return current !== previous ? count + 1 : count;
@@ -1067,7 +1069,9 @@ export default function Page() {
                 {
                   title: "State Transitions",
                   value:
-                    stateTransitions === undefined ? undefined : stateTransitions,
+                    stateTransitions === undefined
+                      ? undefined
+                      : stateTransitions,
                   valueRenderer: formatCount,
                   badThreshold: (v) =>
                     (v ?? 0) > (dailyHealthPercentages?.length || 1) * 0.3,