Skip to content

Vllm build metrics and tabs #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 24, 2025
Merged

Vllm build metrics and tabs #7432

merged 9 commits into from
Nov 24, 2025

Conversation

@rzabarazesh
Copy link
Contributor

@rzabarazesh rzabarazesh commented Nov 4, 2025

This pr adds:

  • Per job duration metrics
  • Docker build metrics
  • Replaces section separator with tabs since the main view was getting too crowded

@vercel
Copy link

vercel bot commented Nov 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Nov 24, 2025 6:14pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@rzabarazesh rzabarazesh requested a review from huydhn November 4, 2025 03:40
huydhn
huydhn reviewed Nov 9, 2025
View reviewed changes
torchci/clickhouse_queries/vllm/docker_build_runtime/query.sql Outdated
WHERE
tupleElement(pipeline, 'repository') = {repo: String }
AND tupleElement(build, 'branch') = 'main'
AND tupleElement(job, 'name') = ':docker: build image'
Copy link
Contributor

@huydhn huydhn Nov 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, you could consider making this job name an input parameter, then you can reuse this query to get the runtime of other jobs too, not only :docker: build image

Copy link
Contributor Author

@rzabarazesh rzabarazesh Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@rzabarazesh rzabarazesh force-pushed the vllm-build-metrics-and-tabs branch from 71eed29 to 9f02058 Compare November 24, 2025 17:27
@rzabarazesh rzabarazesh force-pushed the vllm-build-metrics-and-tabs branch from 3efaeb8 to a5098b9 Compare November 24, 2025 18:12
@rzabarazesh rzabarazesh merged commit 2ae496f into main Nov 24, 2025
5 checks passed
@rzabarazesh rzabarazesh deleted the vllm-build-metrics-and-tabs branch November 24, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzabarazesh @huydhn