Skip to content

Commit 4f64548

Browse files
CIBW which nvcc
1 parent 8ae1611 commit 4f64548

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/workflows/testing_wheels.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ jobs:
4545
CIBW_REPAIR_WHEEL_COMMAND_MACOS: ""
4646
# due to package and module name conflict have to temporarily move it away to run tests
4747
CIBW_BEFORE_TEST: "mv {package}/qsimcirq /tmp"
48+
CIBW_TEST_COMMAND_LINUX: "which nvcc"
4849
CIBW_TEST_COMMAND: "pytest {package}/qsimcirq_tests/qsimcirq_test.py && mv /tmp/qsimcirq {package}"
4950
steps:
5051
- uses: actions/checkout@v2
@@ -53,13 +54,15 @@ jobs:
5354
- uses: actions/setup-python@v2
5455

5556
# Install NVCC on Ubuntu to include GPU in the wheel.
56-
# TODO: open issues
57+
# TODO: some remaining issues
5758
# - `which nvcc` finds nothing? (need to add to path?)
5859
# - nope, confirmed working at workflow level
5960
# - might still be unavailable lower down? seems unlikely
6061
# - still skipping GPU-based tests
6162
# - checks suggest CUDA is on the path...what now?
6263
# - might not be getting to CIBW
64+
# - tested CIBW_ENVIRONMENT: PATH=$PATH, no visible change
65+
# - new test: `which nvcc` in CIBW
6366
# - testing GPU on non-GPU machine will fail
6467
- name: cuda-toolkit
6568
if: ${{ matrix.os == 'ubuntu-20.04' }}
@@ -81,7 +84,7 @@ jobs:
8184

8285
- name: Build wheels
8386
env:
84-
CIBW_ENVIRONMENT: PATH=$PATH
87+
CIBW_ENVIRONMENT: "PATH=$PATH"
8588
run: python -m cibuildwheel --output-dir wheelhouse
8689

8790
- uses: actions/upload-artifact@v2

0 commit comments

Comments
 (0)