Check/lint all files, not changed files

Per review comments by @pavoljuhas, for simplicity and because this code
base is fairly small, using an action to find changed files is not worth
the added complexity.

Author: mhucka

.github/workflows/ci.yaml

@@ -66,15 +66,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Get a list of changed Python files
-        id: changes
-        uses: tj-actions/changed-files@24d32ffd492484c1d75e0c0b894501ddb9d30d62 # v47
-        with:
-          base_sha: ${{inputs.base_sha}}
-          files: '**/*.py'
-
       - name: Set up Python
-        if: steps.changes.outputs.any_changed == 'true'
         uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v5
         with:
           python-version: ${{env.python-version}}
@@ -84,21 +76,18 @@ jobs:
             dev-requirements.txt
 
       - name: Install dependencies
-        if: steps.changes.outputs.any_changed == 'true'
         run: pip install -r requirements.txt -r dev-requirements.txt
 
-      - name: Check the format of changed Python files
-        if: steps.changes.outputs.any_changed == 'true'
+      - name: Check format
         run: |
           echo '::add-matcher::.github/problem-matchers/flynt.json'
           echo '::add-matcher::.github/problem-matchers/black.json'
-          check/format-incremental ${{inputs.base_sha}}
+          check/format-incremental --all
 
-      - name: Lint the changed Python files
-        if: steps.changes.outputs.any_changed == 'true'
+      - name: Check lint
         run: |
           echo '::add-matcher::.github/problem-matchers/pylint.json'
-          pylint -j 0 -v ${{steps.changes.outputs.all_changed_files}}
+          pylint -j 0 -v .
 
   docker-lint:
     name: Dockerfile lint checks
@@ -110,19 +99,12 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Determine if Docker files were changed
-        id: changes
-        uses: tj-actions/changed-files@24d32ffd492484c1d75e0c0b894501ddb9d30d62 # v47
-        with:
-          files: '**/Dockerfile'
-
-      - name: Run hadolint on Dockerfiles that have been changed
-        if: steps.changes.outputs.any_changed == 'true'
+      - name: Run hadolint on Dockerfiles
         env:
           hadolint_version: 'sha256:e9dbf5113239ef2bf696d20c8f28d3019a47c26a38c98b89344d3e2846c4d5f8'
         run: |
           echo '::add-matcher::.github/problem-matchers/hadolint.json'
-          for file in ${{steps.changes.outputs.all_changed_files}}; do
+          find . -name Dockerfile | while IFS= read -r file; do
             echo "Checking ${file} ..."
             docker run --rm -i -v "${PWD}"/.hadolint.yaml:/.config/hadolint.yaml \
               ghcr.io/hadolint/hadolint@${{env.hadolint_version}} < "${file}"
@@ -139,21 +121,18 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Determine if shell scripts were changed
-        id: changes
-        uses: tj-actions/changed-files@24d32ffd492484c1d75e0c0b894501ddb9d30d62 # v47
+      - name: Install problem matcher
+        run: echo '::add-matcher::.github/problem-matchers/shellcheck.json'
+
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@master
         with:
-          base_sha: ${{inputs.base_sha}}
-          files: |
-            **/*.sh
+          severity: error
+          check_together: 'yes'
+          additional_files: >-
             check/format-incremental
-
-      - name: Run shellcheck on shell scripts that have been changed
-        if: steps.changes.outputs.any_changed == 'true'
-        run: |
-          echo "::add-matcher::.github/problem-matchers/shellcheck.json"
-          shellcheck --version
-          shellcheck ${{steps.changes.outputs.all_changed_files}}
+            check/pylint
+            check/pylint-changed-files
 
   yaml-lint:
     name: YAML lint checks
@@ -165,27 +144,17 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Get a list of changed YAML files
-        id: changes
-        uses: tj-actions/changed-files@24d32ffd492484c1d75e0c0b894501ddb9d30d62 # v47
-        with:
-          base_sha: ${{inputs.base_sha}}
-          files: '**/*.{yaml,yml}'
-          # Ignore GHA workflows here. A separate job handles workflow files.
-          files_ignore: .github/workflows/**
-
       - name: Install yamllint
-        if: steps.changes.outputs.any_changed == 'true'
         run: |
           sudo apt-get update
           sudo apt-get install --no-install-recommends -y yamllint
 
       - name: Lint the YAML files
-        if: steps.changes.outputs.any_changed == 'true'
         run: |
           echo "::add-matcher::.github/problem-matchers/yamllint.json"
-          yamllint --version
-          yamllint -f github ${{steps.changes.outputs.all_changed_files}}
+          find . -name '*.yaml' -o -name '*.yml' | \
+            grep -vE '\\.github/workflows' | \
+            xargs yamllint -f github
 
   bazel-lint:
     name: Bazel build lint checks
@@ -197,28 +166,17 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Determine if Bazel files were changed
-        id: changes
-        uses: tj-actions/changed-files@24d32ffd492484c1d75e0c0b894501ddb9d30d62 # v47
-        with:
-          base_sha: ${{inputs.base_sha}}
-          files: |
-            **/BUILD
-            **/*.bzl
-            WORKSPACE
-
       - name: Install buildifier
-        if: steps.changes.outputs.any_changed == 'true'
         uses: jbajic/setup-buildifier@c558ee05c6f74ab5753ff794516750b4aadac296 # v1
         with:
           buildifier-version: '8.2.1'
 
-      - name: Run Buildifier in lint mode on changed files
-        if: steps.changes.outputs.any_changed == 'true'
+      - name: Run Buildifier in lint mode
         run: |
           echo '::add-matcher::.github/problem-matchers/buildifier.json'
-          buildifier --version
-          buildifier -mode=diff -lint=warn ${{steps.changes.outputs.all_changed_files}}
+          # shellcheck disable=SC2038
+          find . -name 'BUILD' -o -name '*.bzl' -o -name 'WORKSPACE' | \
+            xargs buildifier -mode=diff -lint=warn
 
   action-lint:
     name: GitHub Actions lint checks
@@ -230,19 +188,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Determine if workflow files were changed
-        id: changes
-        uses: tj-actions/changed-files@24d32ffd492484c1d75e0c0b894501ddb9d30d62 # v47
-        with:
-          base_sha: ${{inputs.base_sha}}
-          files: .github/workflows/*.{yaml,yml}
-
       - name: Run actionlint
-        if: steps.changes.outputs.any_changed == 'true'
         uses: raven-actions/actionlint@3a24062651993d40fed1019b58ac6fbdfbf276cc # v2
         with:
-          # Note: pass the list of files here, not via the "files:" parameter.
-          flags: ${{inputs.debug && '-verbose'}} ${{steps.changes.outputs.all_changed_files}}
+          flags: ${{inputs.debug && '-verbose'}} .github/workflows/*.{yaml,yml}
           pyflakes: false
 
   library-tests: