refactor: corrected some aspects out of eslint feedback (pattern-lab#1399)

* refactor: fixed 'warning  'data' is assigned a value but never used  no-unused-vars'

its usage has been removed with pattern-lab@70fe9b6#diff-75bedd8b06cebb50236c7c659b539b0fa984746f8abb3d7a5dc6a92b3763fcc0

* refactor: fixed "warning  'event' is defined but never used          no-unused-vars"

* refactor: fixed "warning  'NodePart' is defined but never used                 no-unused-vars"

This isn't in use anymore since commit pattern-lab@2ff8e1c#diff-b26f09ed0fc0febb6d869ff60e410d9d8efd300b4b6c2facbf668cd4555e27a2L39

* refactor: fixed "warning  'customElement' is defined but never used  no-unused-vars"

* refactor: fixed "warning  'previousValues' is assigned a value but never used  no-unused-vars"

as its usage hasn't been in use since commit pattern-lab@2ff8e1c#diff-b26f09ed0fc0febb6d869ff60e410d9d8efd300b4b6c2facbf668cd4555e27a2R45

* refactor: fixed "error  Method 'slotify' expected a return value  consistent-return"

* refactor: fixed "warning  'unsafeCSS' is defined but never used  no-unused-vars"

and css and svg as well

* refactor: fixed "warning  'event' is defined but never used  no-unused-vars"

* refactor: fixed "warning  'event' is defined but never used     no-unused-vars"

and filePath as well

* refactor: fixed "warning  'pm' is assigned a value but never used  no-unused-vars"

as its usage has been removed with commit pattern-lab@deb4783#diff-25426a917b53575c0f0efc5674ee70c4d2c8671f9ade4f9d994db43c9552302bL217

* refactor: fixed "warning  'options' is defined but never used  no-unused-vars"

* chore: removing the previously out-commented parts

Author: mfranzke

packages/uikit-workshop/build/webpack-server.js

@@ -39,7 +39,7 @@ async function serve(patternlab, configPath, buildDir = 'public') {
   const filesToWatch = [
     {
       match: [`${process.cwd()}/patternlab-config.json`],
-      fn: async function (event, filePath) {
+      fn: async function () {
         // when the main PL config changes, clear Node's cache (so the JSON config is re-read) and trigger another PL build
         // this allows config changes to show up without restarting the build!
         Object.keys(require.cache).forEach(function (key) {

packages/uikit-workshop/src/scripts/components/panels.js

@@ -46,7 +46,7 @@ export const Panels = {
   },
 };
 
-function init(event) {
+function init() {
   // does the origin sending the message match the current host? if not dev/null the request
 
   const fileSuffixPattern =

packages/uikit-workshop/src/scripts/lit-components/pl-icon/pl-icon.js

@@ -1,11 +1,4 @@
-import {
-  html,
-  LitElement,
-  unsafeCSS,
-  css,
-  svg,
-  customElement,
-} from 'lit-element';
+import { html, LitElement, customElement } from 'lit-element';
 import styles from './pl-icon.scss?external';
 import { unsafeHTML } from 'lit-html/directives/unsafe-html';
 const icons = {};

packages/uikit-workshop/src/scripts/lit-components/pl-icon/unsafe-svg.js

@@ -14,7 +14,7 @@
 
 import { reparentNodes } from 'lit-html/lib/dom.js';
 // import { isPrimitive } from 'lit-html/lib/parts.js';
-import { directive, NodePart } from 'lit-html/lit-html.js';
+import { directive } from 'lit-html/lit-html.js';
 import importNode from '@ungap/import-node';
 // document.importNode = importNode;
 
@@ -28,7 +28,6 @@ import importNode from '@ungap/import-node';
 // The DocumentFragment is used as a unique key to check if the last value
 // rendered to the part was with unsafeSVG. If not, we'll always re-render the
 // value passed to unsafeSVG.
-const previousValues = new WeakMap();
 
 /**
  * Renders the result as SVG, rather than text.

packages/uikit-workshop/src/scripts/lit-components/pl-tooltip/pl-tooltip.js

@@ -1,4 +1,4 @@
-import { LitElement, html, customElement } from 'lit-element';
+import { LitElement, html } from 'lit-element';
 import styles from './pl-tooltip.scss?external';
 import { Slotify } from '../slotify';
 

packages/uikit-workshop/src/scripts/lit-components/slotify.js

@@ -71,6 +71,7 @@ export const Slotify = (Base) =>
       } else if (defaultContent) {
         return defaultContent;
       } else {
+        // eslint-disable-next-line consistent-return
         return;
       }
     }

packages/uikit-workshop/src/scripts/utils/url-handler.js

@@ -155,10 +155,6 @@ export const urlHandler = {
    * @param  {String}       the path given by the loaded iframe
    */
   pushPattern(pattern, givenPath) {
-    const data = {
-      pattern,
-    };
-
     const fileName = urlHandler.getFileName(pattern);
     let path = window.location.pathname;
     path =
@@ -216,6 +212,6 @@ export const urlHandler = {
 /**
  * handle the onpopstate event
  */
-window.onpopstate = function (event) {
+window.onpopstate = function () {
   urlHandler.skipBack = true;
 };