Skip to content

Commit 1941bfa

Browse files
committed
don't ignore indefinitely failing seeds
1 parent fabe975 commit 1941bfa

File tree

1 file changed

+4
-2
lines changed
  • quickwit/quickwit-config/src/node_config

1 file changed

+4
-2
lines changed

quickwit/quickwit-config/src/node_config/mod.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -618,15 +618,17 @@ impl NodeConfig {
618618
// validation purposes. Additionally, we need to append a default port if necessary and
619619
// finally return the addresses as strings, which is tricky for IPv6. We let the logic baked
620620
// in `HostAddr` handle this complexity.
621+
let mut found_something = false;
621622
for peer_seed in &self.peer_seeds {
622623
let peer_seed_addr = HostAddr::parse_with_default_port(peer_seed, default_gossip_port)?;
623624
if let Err(error) = peer_seed_addr.resolve().await {
624625
warn!(peer_seed = %peer_seed_addr, error = ?error, "failed to resolve peer seed address");
625-
continue;
626+
} else {
627+
found_something = true;
626628
}
627629
peer_seed_addrs.push(peer_seed_addr.to_string())
628630
}
629-
if !self.peer_seeds.is_empty() && peer_seed_addrs.is_empty() {
631+
if !self.peer_seeds.is_empty() && !found_something {
630632
warn!("failed to resolve all the peer seed addresses")
631633
}
632634
Ok(peer_seed_addrs)

0 commit comments

Comments
 (0)