Commit dbcc250
committed
metastore: skip checkpoint log when beginning
This log is written on every partition, even when there's no data loss.
The position.cmp(&delta_position.from) comparison doesn't account for
Position::Beginning being not equal to Position::offset(0u64). However logically
speaking moving from Beginning to 0u64 doesn't indicate any data loss -
Position::Beginning means that no data was processed, and Position::offset(0)
means offset 0 was processed.
I have run 'test_process_existing_messages' at
quickwit/quickwit-indexing/src/source/queue_sources/coordinator.rs
and confirmed that the delta is -
SourceCheckpointDelta[Position::offset(0)..Position::eof(file_len)]
and not -
SourceCheckpointDelta[Position::Beginning..Position::eof(file_len)]1 parent a58b6de commit dbcc250
1 file changed
+5
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
297 | 301 | | |
298 | 302 | | |
299 | 303 | | |
| |||
0 commit comments