From 4056baf259615a94f58bcc5afdac760b58bba062 Mon Sep 17 00:00:00 2001 From: Rashidi Zin Date: Sat, 30 Aug 2025 20:08:21 +0800 Subject: [PATCH 1/3] Fix Sonar blocker issues --- data-jdbc-schema-generation/.gitignore | 3 +++ .../DataJdbcSchemaGenerationApplicationTests.java | 15 --------------- .../boot/jdbcscgm/book/BookRepositoryTests.java | 11 ++++++----- 3 files changed, 9 insertions(+), 20 deletions(-) delete mode 100644 data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/DataJdbcSchemaGenerationApplicationTests.java diff --git a/data-jdbc-schema-generation/.gitignore b/data-jdbc-schema-generation/.gitignore index c2065bc2..3da6325c 100644 --- a/data-jdbc-schema-generation/.gitignore +++ b/data-jdbc-schema-generation/.gitignore @@ -35,3 +35,6 @@ out/ ### VS Code ### .vscode/ + +### Liquibase generated files ### +./src/main/resources/db/changelog/user.yaml \ No newline at end of file diff --git a/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/DataJdbcSchemaGenerationApplicationTests.java b/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/DataJdbcSchemaGenerationApplicationTests.java deleted file mode 100644 index e931cc1f..00000000 --- a/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/DataJdbcSchemaGenerationApplicationTests.java +++ /dev/null @@ -1,15 +0,0 @@ -package zin.rashidi.boot.jdbcscgm; - -import org.junit.jupiter.api.Test; -import org.springframework.boot.test.context.SpringBootTest; -import org.springframework.context.annotation.Import; - -@Import(TestcontainersConfiguration.class) -@SpringBootTest -class DataJdbcSchemaGenerationApplicationTests { - - @Test - void contextLoads() { - } - -} diff --git a/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/book/BookRepositoryTests.java b/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/book/BookRepositoryTests.java index 558b2c71..1dc3b6c7 100644 --- a/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/book/BookRepositoryTests.java +++ b/data-jdbc-schema-generation/src/test/java/zin/rashidi/boot/jdbcscgm/book/BookRepositoryTests.java @@ -1,6 +1,7 @@ package zin.rashidi.boot.jdbcscgm.book; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.autoconfigure.data.jdbc.DataJdbcTest; @@ -13,6 +14,8 @@ import java.io.IOException; import java.util.Set; +import static org.assertj.core.api.Assertions.assertThat; + /** * @author Rashidi Zin */ @@ -28,12 +31,10 @@ static void generateSchema(@Autowired RelationalMappingContext context) throws I writer.writeChangeSet(new FileSystemResource("user.yaml")); } - @Autowired - private BookRepository books; - @Test - void findAll() { - books.findAll(); + @DisplayName("Given the user.yaml exists, when changelogExists, then return true") + void changelogExists() { + assertThat(new FileSystemResource("user.yaml").exists()).isTrue(); } } From fa0e1e68e2ccc9296d716d332d637f366a451f8a Mon Sep 17 00:00:00 2001 From: Rashidi Zin Date: Sat, 30 Aug 2025 20:09:27 +0800 Subject: [PATCH 2/3] Fix Sonar blocker issues --- data-jdbc-schema-generation/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data-jdbc-schema-generation/.gitignore b/data-jdbc-schema-generation/.gitignore index 3da6325c..f882e00f 100644 --- a/data-jdbc-schema-generation/.gitignore +++ b/data-jdbc-schema-generation/.gitignore @@ -37,4 +37,4 @@ out/ .vscode/ ### Liquibase generated files ### -./src/main/resources/db/changelog/user.yaml \ No newline at end of file +**/user.yaml From 50f6be3c5d43c7a307dbec378c12d6ef3d301f8b Mon Sep 17 00:00:00 2001 From: Rashidi Zin Date: Sat, 30 Aug 2025 20:11:14 +0800 Subject: [PATCH 3/3] Fix Sonar blocker issues --- .github/workflows/gradle-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build.yml b/.github/workflows/gradle-build.yml index f8ab550d..62c7bf17 100644 --- a/.github/workflows/gradle-build.yml +++ b/.github/workflows/gradle-build.yml @@ -49,7 +49,7 @@ jobs: gradle-build: name: Build project with Gradle needs: check-changes - if: ${{ needs.check-changes.outputs.build-changes == 'true' }} + if: ${{ needs.check-changes.outputs.build-changes == 'true' || needs.check-changes.outputs.source-changes == 'true' }} runs-on: ubuntu-latest outputs: build-artifacts: ${{ steps.upload-build-artifacts.outputs.artifact-id }}