fix(TextBox): update Text patching to allow for proper centering

Author: ImCoolNowRight

packages/@lightningjs/ui-components/src/components/InlineContent/InlineContent.js

@@ -139,7 +139,10 @@ export default class InlineContent extends Base {
 
   _notifyAncestors() {
     this.fireAncestors('$loadedInlineContent', this);
-    this.signal('loadedInlineContent', this.finalW, this.multiLineHeight);
+    this.signal('loadedInlineContent', {
+      w: this.finalW,
+      h: this.multiLineHeight
+    });
   }
 
   _contentLoaded() {

packages/@lightningjs/ui-components/src/components/InlineContent/InlineContent.test.js

@@ -371,11 +371,10 @@ describe('InlineContent', () => {
       '$loadedInlineContent',
       inlineContent
     );
-    expect(inlineContent.signal).toHaveBeenCalledWith(
-      'loadedInlineContent',
-      inlineContent.finalW,
-      inlineContent.multiLineHeight
-    );
+    expect(inlineContent.signal).toHaveBeenCalledWith('loadedInlineContent', {
+      w: inlineContent.finalW,
+      h: inlineContent.multiLineHeight
+    });
   });
 
   it('should truncate content that exceeds the defined max lines', async () => {

packages/@lightningjs/ui-components/src/components/TextBox/TextBox.js

@@ -71,7 +71,7 @@ export default class TextBox extends Base {
     ];
   }
 
-  _setDimensions(w, h) {
+  _setDimensions({ w, h }) {
     let width = w;
     let height = h;
     if (!this._isInlineContent) {
@@ -82,7 +82,8 @@ export default class TextBox extends Base {
     const sizeChanged = this.w !== width || this.h !== height;
 
     if (width && height && sizeChanged) {
-      this.h = height;
+      this.h =
+        height * (this._isInlineContent ? 1 : this.stage.getRenderPrecision());
       if (!this.fixed) {
         this.w = width;
       }
@@ -197,14 +198,30 @@ export default class TextBox extends Base {
     const fontStyle = this._textStyleSet;
 
     if (this._Text) {
-      this._Text.patch({
+      let patchObj = {
+        w: w => w,
         y: this.style.offsetY,
-        x: this.style.offsetX,
-        text: {
-          ...lightningTextDefaults, // order matters this should always be first
-          ...fontStyle
-        }
+        x: this.style.offsetX
+      };
+
+      const textString = JSON.stringify({
+        ...lightningTextDefaults, // order matters this should always be first
+        ...fontStyle
       });
+
+      if (textString !== this._textString) {
+        patchObj = {
+          ...patchObj,
+
+          text: {
+            ...lightningTextDefaults, // order matters this should always be first
+            ...fontStyle
+          }
+        };
+        this._textString = textString;
+      }
+
+      this._Text.patch(patchObj);
     }
   }