Skip to content

Commit 643af79

Browse files
committed
Avoid to check for reachability everytime we make a call
1 parent 90d51b7 commit 643af79

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,9 @@ public String getName() {
122122

123123
@ReactMethod
124124
public void setup(ReadableMap options) {
125+
Log.d(TAG, "setup");
125126
VoiceConnectionService.setAvailable(false);
127+
VoiceConnectionService.setInitialized(true);
126128
this._settings = options;
127129

128130
if (isConnectionServiceAvailable()) {

android/src/main/java/io/wazo/callkeep/VoiceConnectionService.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@
6969
// @see https://github.com/kbagchiGWC/voice-quickstart-android/blob/9a2aff7fbe0d0a5ae9457b48e9ad408740dfb968/exampleConnectionService/src/main/java/com/twilio/voice/examples/connectionservice/VoiceConnectionService.java
7070
@TargetApi(Build.VERSION_CODES.M)
7171
public class VoiceConnectionService extends ConnectionService {
72-
private static Boolean isAvailable;
73-
private static Boolean isInitialized;
74-
private static Boolean isReachable;
72+
private static Boolean isAvailable = false;
73+
private static Boolean isInitialized = false;
74+
private static Boolean isReachable = false;
7575
private static Boolean canMakeMultipleCalls = true;
7676
private static String notReachableCallUuid;
7777
private static ConnectionRequest currentConnectionRequest;
@@ -92,9 +92,6 @@ public static Connection getConnection(String connectionId) {
9292
public VoiceConnectionService() {
9393
super();
9494
Log.e(TAG, "Constructor");
95-
isReachable = false;
96-
isInitialized = false;
97-
isAvailable = false;
9895
currentConnectionRequest = null;
9996
currentConnectionService = this;
10097
}
@@ -106,7 +103,7 @@ public static void setPhoneAccountHandle(PhoneAccountHandle phoneAccountHandle)
106103
public static void setAvailable(Boolean value) {
107104
Log.d(TAG, "setAvailable: " + (value ? "true" : "false"));
108105
if (value) {
109-
isInitialized = true;
106+
setInitialized(true);
110107
}
111108

112109
isAvailable = value;
@@ -126,6 +123,12 @@ public static void setReachable() {
126123
VoiceConnectionService.currentConnectionRequest = null;
127124
}
128125

126+
public static void setInitialized(boolean value) {
127+
Log.d(TAG, "setInitialized: " + (value ? "true" : "false"));
128+
129+
isInitialized = value;
130+
}
131+
129132
public static void deinitConnection(String connectionId) {
130133
Log.d(TAG, "deinitConnection:" + connectionId);
131134
VoiceConnectionService.hasOutgoingCall = false;

0 commit comments

Comments
 (0)