py37 compat

Author: rmorshea

flake8_idom_hooks/exhaustive_deps.py

@@ -141,7 +141,8 @@ def _get_dependency_names_from_expression(
                     )
             return dep_names
         elif not (
-            isinstance(dependency_expr, ast.Constant) and dependency_expr.value is None
+            isinstance(dependency_expr, (ast.Constant, ast.NameConstant))
+            and dependency_expr.value is None
         ):
             self._save_error(
                 201,

flake8_idom_hooks/flake8_plugin.py

@@ -14,6 +14,8 @@ class Plugin:
     name = __name__
     version = __version__
 
+    options: Namespace = Namespace()
+
     @classmethod
     def add_options(cls, option_manager: OptionManager) -> None:
         option_manager.add_option(
@@ -34,5 +36,7 @@ def __init__(self, tree: ast.Module) -> None:
     def run(self) -> list[tuple[int, int, str, type[Plugin]]]:
         return [
             error + (self.__class__,)
-            for error in run_checks(self._tree, self.options.exhaustive_hook_deps)
+            for error in run_checks(
+                self._tree, getattr(self.options, "exhaustive_hook_deps", False)
+            )
         ]

flake8_idom_hooks/run.py

@@ -2,6 +2,7 @@
 
 import ast
 
+from .utils import ErrorVisitor
 from .exhaustive_deps import ExhaustiveDepsVisitor
 from .rules_of_hooks import RulesOfHooksVisitor
 
@@ -10,7 +11,7 @@ def run_checks(
     tree: ast.Module,
     exhaustive_hook_deps: bool,
 ) -> list[tuple[int, int, str]]:
-    visitor_types = [RulesOfHooksVisitor]
+    visitor_types: list[type[ErrorVisitor]] = [RulesOfHooksVisitor]
     if exhaustive_hook_deps:
         visitor_types.append(ExhaustiveDepsVisitor)
 

requirements/lint.txt

@@ -1,3 +1,4 @@
 flake8 >=3.7
 black
 mypy
+types-setuptools