Skip to content

Commit d746ddf

Browse files
committed
Merge remote-tracking branch 'upstream/main' into pr/1191
2 parents 3c0c35a + 1dcba7c commit d746ddf

File tree

32 files changed

+241
-179
lines changed

32 files changed

+241
-179
lines changed

.github/pull_request_template.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
<sub>By submitting this pull request you agree that all contributions to this project are made under the MIT license.</sub>
1+
## Description
22

3-
## Issues
3+
<!-- A summary of the changes. -->
44

5-
<!-- Describe or link the issues this change resolves -->
6-
7-
## Solution
5+
## Checklist
86

9-
<!-- Describe how these changes resolve the aforementioned issues -->
7+
Please update this checklist as you complete each item:
108

11-
## Checklist
9+
- [ ] Tests have been developed for bug fixes or new functionality.
10+
- [ ] The changelog has been updated, if necessary.
11+
- [ ] Documentation has been updated, if necessary.
12+
- [ ] GitHub Issues closed by this PR have been linked.
1213

13-
- [ ] Tests have been included for all bug fixes or added functionality.
14-
- [ ] The `changelog.rst` has been updated with any significant changes.
14+
<sub>By submitting this pull request I agree that all contributions comply with this project's open source license(s).</sub>

.github/workflows/.hatch-run.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ jobs:
3838
runs-on: ${{ fromJson(inputs.runs-on-array) }}
3939
runs-on: ${{ matrix.runs-on }}
4040
steps:
41-
- uses: actions/checkout@v2
42-
- uses: actions/setup-node@v2
41+
- uses: actions/checkout@v4
42+
- uses: actions/setup-node@v4
4343
with:
44-
node-version: "14.x"
44+
node-version: "23.x"
4545
registry-url: ${{ inputs.node-registry-url }}
4646
- name: Pin NPM Version
4747
run: npm install -g npm@8.19.3
4848
- name: Use Python ${{ matrix.python-version }}
49-
uses: actions/setup-python@v2
49+
uses: actions/setup-python@v5
5050
with:
5151
python-version: ${{ matrix.python-version }}
5252
- name: Install Python Dependencies

.github/workflows/deploy-docs.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@
44
name: deploy-docs
55

66
on:
7-
push:
8-
branches:
9-
- "main"
10-
tags:
11-
- "*"
7+
push:
8+
branches:
9+
- "main"
10+
tags:
11+
- "*"
1212

1313
jobs:
14-
deploy-documentation:
15-
runs-on: ubuntu-latest
16-
steps:
17-
- name: Check out src from Git
18-
uses: actions/checkout@v2
19-
- name: Get history and tags for SCM versioning to work
20-
run: |
21-
git fetch --prune --unshallow
22-
git fetch --depth=1 origin +refs/tags/*:refs/tags/*
23-
- name: Login to Heroku Container Registry
24-
run: echo ${{ secrets.HEROKU_API_KEY }} | docker login -u ${{ secrets.HEROKU_EMAIL }} --password-stdin registry.heroku.com
25-
- name: Build Docker Image
26-
run: docker build . --file docs/Dockerfile --tag registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web
27-
- name: Push Docker Image
28-
run: docker push registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web
29-
- name: Deploy
30-
run: HEROKU_API_KEY=${{ secrets.HEROKU_API_KEY }} heroku container:release web --app ${{ secrets.HEROKU_APP_NAME }}
14+
deploy-documentation:
15+
runs-on: ubuntu-latest
16+
steps:
17+
- name: Check out src from Git
18+
uses: actions/checkout@v4
19+
- name: Get history and tags for SCM versioning to work
20+
run: |
21+
git fetch --prune --unshallow
22+
git fetch --depth=1 origin +refs/tags/*:refs/tags/*
23+
- name: Login to Heroku Container Registry
24+
run: echo ${{ secrets.HEROKU_API_KEY }} | docker login -u ${{ secrets.HEROKU_EMAIL }} --password-stdin registry.heroku.com
25+
- name: Build Docker Image
26+
run: docker build . --file docs/Dockerfile --tag registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web
27+
- name: Push Docker Image
28+
run: docker push registry.heroku.com/${{ secrets.HEROKU_APP_NAME }}/web
29+
- name: Deploy
30+
run: HEROKU_API_KEY=${{ secrets.HEROKU_API_KEY }} heroku container:release web --app ${{ secrets.HEROKU_APP_NAME }}

.github/workflows/publish.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44
name: publish
55

66
on:
7-
release:
8-
types: [published]
7+
release:
8+
types: [published]
99

1010
jobs:
11-
publish:
12-
uses: ./.github/workflows/.hatch-run.yml
13-
with:
14-
job-name: "publish"
15-
hatch-run: "publish"
16-
node-registry-url: "https://registry.npmjs.org"
17-
secrets:
18-
node-auth-token: ${{ secrets.NODE_AUTH_TOKEN }}
19-
pypi-username: ${{ secrets.PYPI_USERNAME }}
20-
pypi-password: ${{ secrets.PYPI_PASSWORD }}
11+
publish:
12+
uses: ./.github/workflows/.hatch-run.yml
13+
with:
14+
job-name: "publish"
15+
hatch-run: "publish"
16+
node-registry-url: "https://registry.npmjs.org"
17+
secrets:
18+
node-auth-token: ${{ secrets.NODE_AUTH_TOKEN }}
19+
pypi-username: ${{ secrets.PYPI_USERNAME }}
20+
pypi-password: ${{ secrets.PYPI_PASSWORD }}

.vscode/extensions.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"recommendations": [
3+
"wholroyd.jinja",
4+
"esbenp.prettier-vscode",
5+
"ms-python.vscode-pylance",
6+
"ms-python.python",
7+
"charliermarsh.ruff",
8+
"dbaeumer.vscode-eslint",
9+
"ms-python.black-formatter",
10+
"ms-python.mypy-type-checker"
11+
]
12+
}

docs/source/about/changelog.rst

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,10 @@ Changelog
33

44
.. note::
55

6-
The ReactPy team manages their short and long term plans with `GitHub Projects
7-
<https://github.com/orgs/reactive-python/projects/1>`__. If you have questions about what
8-
the team are working on, or have feedback on how issues should be prioritized, feel
9-
free to :discussion-type:`open up a discussion <question>`.
10-
11-
All notable changes to this project will be recorded in this document. The style of
12-
which is based on `Keep a Changelog <https://keepachangelog.com/>`__. The versioning
13-
scheme for the project adheres to `Semantic Versioning <https://semver.org/>`__. For
14-
more info, see the :ref:`Contributor Guide <Creating a Changelog Entry>`.
6+
All notable changes to this project will be recorded in this document. The style of
7+
which is based on `Keep a Changelog <https://keepachangelog.com/>`__. The versioning
8+
scheme for the project adheres to `Semantic Versioning <https://semver.org/>`__. For
9+
more info, see the :ref:`Contributor Guide <Creating a Changelog Entry>`.
1510

1611

1712
.. INSTRUCTIONS FOR CHANGELOG CONTRIBUTORS
@@ -25,15 +20,18 @@ Unreleased
2520

2621
**Fixed**
2722

28-
- :pull:`1118` - `module_from_template` is broken with a recent release of `requests`
29-
- :pull:`1131` - `module_from_template` did not work when using Flask backend
23+
- :pull:`1118` - ``module_from_template`` is broken with a recent release of ``requests``
24+
- :pull:`1131` - ``module_from_template`` did not work when using Flask backend
25+
- :pull:`1200` - Fixed ``UnicodeDecodeError`` when using ``reactpy.web.export``
26+
- :pull:`1224` - Fixes needless unmounting of JavaScript components during each ReactPy render.
27+
- :pull:`1126` - Fixed missing ``event["target"]["checked"]`` on checkbox inputs
3028

3129
**Added**
3230

33-
- :pull:`1165` - Allow concurrent renders of discrete component tree - enable this
34-
experimental feature by setting `REACTPY_ASYNC_RENDERING=true`. This should improve
35-
the overall responsiveness of your app, particularly when handling larger renders
36-
that would otherwise block faster renders from being processed.
31+
- :pull:`1165` - Allow concurrently rendering discrete component trees - enable this
32+
experimental feature by setting ``REACTPY_ASYNC_RENDERING=true``. This improves
33+
the overall responsiveness of your app in situations where larger renders would
34+
otherwise block smaller renders from executing.
3735

3836
**Changed**
3937

@@ -44,12 +42,15 @@ Unreleased
4442
fragment to conditionally render an element by writing
4543
``something if condition else html._()``. Now you can simply write
4644
``something if condition else None``.
45+
- :pull:`1210` - Move hooks from ``reactpy.backend.hooks`` into ``reactpy.core.hooks``.
4746

4847
**Deprecated**
4948

5049
- :pull:`1171` - The ``Stop`` exception. Recent releases of ``anyio`` have made this
5150
exception difficult to use since it now raises an ``ExceptionGroup``. This exception
5251
was primarily used for internal testing purposes and so is now deprecated.
52+
- :pull:`1210` - Deprecate ``reactpy.backend.hooks`` since the hooks have been moved into
53+
``reactpy.core.hooks``.
5354

5455

5556
v1.0.2

pyproject.toml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,11 @@ detached = true
1212
dependencies = [
1313
"invoke",
1414
# lint
15-
"black==24.1.1", # Pin lint tools we don't control to avoid breaking changes
16-
"ruff==0.0.278", # Pin lint tools we don't control to avoid breaking changes
15+
"black==24.1.1", # Pin lint tools we don't control to avoid breaking changes
16+
"ruff==0.0.278", # Pin lint tools we don't control to avoid breaking changes
1717
"toml",
18-
"flake8==7.0.0", # Pin lint tools we don't control to avoid breaking changes
18+
"flake8==7.0.0", # Pin lint tools we don't control to avoid breaking changes
1919
"flake8-pyproject",
20-
"reactpy-flake8 >=0.7",
2120
# types
2221
"mypy",
2322
"types-toml",

src/js/app/package-lock.json

Lines changed: 25 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/js/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"@types/react": "^17.0",
1313
"@types/react-dom": "^17.0",
1414
"typescript": "^4.9.5",
15-
"vite": "^3.2.7"
15+
"vite": "^3.2.11"
1616
},
1717
"repository": {
1818
"type": "git",

0 commit comments

Comments
 (0)