Test: check focus after double clicks (#11700)

### Related

Part of #8948 

### What

- Adds automated test checking what happens on double clicks
- Removes `check_focus.py` from release checklist

Author: aedm

crates/viewer/re_viewer/src/viewer_test_utils/mod.rs

@@ -13,39 +13,48 @@ use crate::{
 #[derive(Default)]
 pub struct HarnessOptions {
     pub window_size: Option<egui::Vec2>,
+    pub max_steps: Option<u64>,
+    pub step_dt: Option<f32>,
 }
 
 /// Convenience function for creating a kittest harness of the viewer App.
 pub fn viewer_harness(options: &HarnessOptions) -> Harness<'static, App> {
     let window_size = options.window_size.unwrap_or(egui::vec2(1024.0, 768.0));
 
-    re_ui::testing::new_harness(re_ui::testing::TestOptions::Rendering3D, window_size).build_eframe(
-        |cc| {
-            cc.egui_ctx.set_os(egui::os::OperatingSystem::Nix);
-            customize_eframe_and_setup_renderer(cc).expect("Failed to customize eframe");
-            let mut app = App::new(
-                MainThreadToken::i_promise_i_am_only_using_this_for_a_test(),
-                build_info!(),
-                AppEnvironment::Test,
-                StartupOptions {
-                    // Don't show the welcome / example screen in tests.
-                    // See also: https://github.com/rerun-io/rerun/issues/10989
-                    hide_welcome_screen: true,
-                    // Don't calculate memory limit in tests.
-                    memory_limit: re_memory::MemoryLimit::UNLIMITED,
-                    ..Default::default()
-                },
-                cc,
-                Some(re_redap_client::ConnectionRegistry::new_without_stored_credentials()),
-                AsyncRuntimeHandle::from_current_tokio_runtime_or_wasmbindgen()
-                    .expect("Failed to create AsyncRuntimeHandle"),
-            );
-            // Force the FFmpeg path to be wrong so we have a reproducible behavior.
-            app.app_options_mut().video_decoder_ffmpeg_path = "/fake/ffmpeg/path".to_owned();
-            app.app_options_mut().video_decoder_override_ffmpeg_path = true;
-            app
-        },
-    )
+    let mut harness_builder =
+        re_ui::testing::new_harness(re_ui::testing::TestOptions::Rendering3D, window_size);
+    if let Some(max_steps) = options.max_steps {
+        harness_builder = harness_builder.with_max_steps(max_steps);
+    }
+    if let Some(step_dt) = options.step_dt {
+        harness_builder = harness_builder.with_step_dt(step_dt);
+    }
+
+    harness_builder.build_eframe(|cc| {
+        cc.egui_ctx.set_os(egui::os::OperatingSystem::Nix);
+        customize_eframe_and_setup_renderer(cc).expect("Failed to customize eframe");
+        let mut app = App::new(
+            MainThreadToken::i_promise_i_am_only_using_this_for_a_test(),
+            build_info!(),
+            AppEnvironment::Test,
+            StartupOptions {
+                // Don't show the welcome / example screen in tests.
+                // See also: https://github.com/rerun-io/rerun/issues/10989
+                hide_welcome_screen: true,
+                // Don't calculate memory limit in tests.
+                memory_limit: re_memory::MemoryLimit::UNLIMITED,
+                ..Default::default()
+            },
+            cc,
+            Some(re_redap_client::ConnectionRegistry::new_without_stored_credentials()),
+            AsyncRuntimeHandle::from_current_tokio_runtime_or_wasmbindgen()
+                .expect("Failed to create AsyncRuntimeHandle"),
+        );
+        // Force the FFmpeg path to be wrong so we have a reproducible behavior.
+        app.app_options_mut().video_decoder_ffmpeg_path = "/fake/ffmpeg/path".to_owned();
+        app.app_options_mut().video_decoder_override_ffmpeg_path = true;
+        app
+    })
 }
 
 /// Steps through the harness until the `predicate` closure returns `true`.

crates/viewer/re_viewer/tests/app_kittest.rs

@@ -22,6 +22,7 @@ async fn settings_screen() {
 
     let mut harness = viewer_test_utils::viewer_harness(&HarnessOptions {
         window_size: Some(egui::vec2(1024.0, 1080.0)), // Settings screen can be a bit tall
+        ..Default::default()
     });
     harness.get_by_label("Menu").click();
     harness.run_ok();

tests/python/release_checklist/check_focus.py

@@ -71,6 +71,9 @@ pub trait HarnessExt<'h> {
     // Get the position of a node in the UI by its label.
     fn get_panel_position(&mut self, label: &str) -> egui::Rect;
 
+    // Click at a position in the UI.
+    fn click_at(&mut self, pos: egui::Pos2);
+
     // Drag-and-drop functions based on position
     fn drag_at(&mut self, pos: egui::Pos2);
     fn hover_at(&mut self, pos: egui::Pos2);
@@ -302,6 +305,18 @@ impl<'h> HarnessExt<'h> for egui_kittest::Harness<'h, re_viewer::App> {
         self.get_by_role_and_label(Role::Pane, label).rect()
     }
 
+    fn click_at(&mut self, pos: egui::Pos2) {
+        for pressed in [true, false] {
+            self.event(egui::Event::PointerButton {
+                pos,
+                button: PointerButton::Primary,
+                pressed,
+                modifiers: Modifiers::NONE,
+            });
+            self.run();
+        }
+    }
+
     fn drag_at(&mut self, pos: egui::Pos2) {
         self.event(egui::Event::PointerButton {
             pos,

tests/rust/re_integration_test/src/kittest_harness_ext.rs

@@ -0,0 +1,132 @@
+//! This test logs a few boxes and performs the following focus checks:
+//!
+//! - Double-click on a box in the first view
+//!   - check ONLY the corresponding view expands and scrolls
+//!   - check the streams view expands and scrolls
+//! - Double-click on the leaf "boxes3d" entity in the streams view, check both views expand (manual scrolling might be needed).
+
+use re_integration_test::HarnessExt as _;
+use re_sdk::TimePoint;
+use re_sdk::log::RowId;
+use re_viewer::external::re_viewer_context::ViewClass as _;
+use re_viewer::external::{re_types, re_view_spatial};
+use re_viewer::viewer_test_utils::{self, HarnessOptions};
+use re_viewport_blueprint::ViewBlueprint;
+
+fn make_test_harness<'a>() -> egui_kittest::Harness<'a, re_viewer::App> {
+    let mut harness = viewer_test_utils::viewer_harness(&HarnessOptions {
+        window_size: Some(egui::vec2(1024.0, 768.0)),
+        max_steps: Some(200),      // Allow animations to finish.
+        step_dt: Some(1.0 / 60.0), // Allow double clicks to go through.
+    });
+    harness.init_recording();
+    harness.set_selection_panel_opened(false);
+
+    // Log some data.
+    harness.log_entity("group/boxes3d", |builder| {
+        builder.with_archetype(
+            RowId::new(),
+            TimePoint::default(),
+            &re_types::archetypes::Boxes3D::from_centers_and_half_sizes(
+                [(1.0, 0.0, 0.0), (0.0, 1.0, 0.0), (1.0, 1.0, 0.0)],
+                [(0.2, 0.4, 0.2), (0.2, 0.2, 0.4), (0.4, 0.2, 0.2)],
+            )
+            .with_colors([0xFF0000FF, 0x00FF00FF, 0x0000FFFF])
+            .with_fill_mode(re_types::components::FillMode::Solid),
+        )
+    });
+    harness.log_entity("txt/hello", |builder| {
+        builder.with_archetype(
+            RowId::new(),
+            TimePoint::STATIC,
+            &re_types::archetypes::TextDocument::new("Hello World!"),
+        )
+    });
+
+    harness
+}
+
+fn setup_single_view_blueprint(harness: &mut egui_kittest::Harness<'_, re_viewer::App>) {
+    harness.clear_current_blueprint();
+
+    let root_cid = harness.add_blueprint_container(egui_tiles::ContainerKind::Horizontal, None);
+    let tab_cid = harness.add_blueprint_container(egui_tiles::ContainerKind::Tabs, Some(root_cid));
+    let vertical_cid =
+        harness.add_blueprint_container(egui_tiles::ContainerKind::Vertical, Some(root_cid));
+
+    let mut view_1 =
+        ViewBlueprint::new_with_root_wildcard(re_view_spatial::SpatialView3D::identifier());
+    view_1.display_name = Some("3D view 1".into());
+    let mut view_2 =
+        ViewBlueprint::new_with_root_wildcard(re_view_spatial::SpatialView3D::identifier());
+    view_2.display_name = Some("3D view 2".into());
+
+    harness.setup_viewport_blueprint(move |_viewer_context, blueprint| {
+        let text_views = (0..20).map(|i| {
+            let mut view = ViewBlueprint::new_with_root_wildcard(
+                re_view_text_document::TextDocumentView::identifier(),
+            );
+            view.display_name = Some(format!("Text view {i}"));
+            view
+        });
+        blueprint.add_views(text_views, Some(tab_cid), None);
+        blueprint.add_views([view_1, view_2].into_iter(), Some(vertical_cid), None);
+    });
+}
+
+#[tokio::test(flavor = "multi_thread")]
+pub async fn test_check_focus() {
+    let mut harness = make_test_harness();
+    setup_single_view_blueprint(&mut harness);
+
+    // Make the left panel wider.
+    let centerline = harness.get_panel_position("Text view 0").left_center();
+    let target_pos = centerline + egui::vec2(100.0, 0.0);
+    harness.drag_at(centerline);
+    harness.snapshot_app("check_focus_1");
+    harness.hover_at(target_pos);
+    harness.snapshot_app("check_focus_2");
+    harness.drop_at(target_pos);
+    harness.snapshot_app("check_focus_3");
+
+    // One of the boxes is at the center of the view.
+    let pixel_of_a_box = harness.get_panel_position("3D view 1").center();
+
+    // Hover over the box.
+    harness.hover_at(pixel_of_a_box);
+
+    // Let the app render. This will run the picking logic which needs the GPU
+    // and lets the app find the hovered box.
+    harness.render().expect("Cannot render app");
+    harness.run();
+    harness.snapshot_app("check_focus_4");
+
+    // Double click on the box, see how it expands the view.
+    harness.click_at(pixel_of_a_box);
+    harness.click_at(pixel_of_a_box);
+    harness.snapshot_app("check_focus_5");
+
+    // Scroll down to see the second view stays collapsed.
+    harness.blueprint_tree().hover_label("3D view 1");
+    harness.event(egui::Event::MouseWheel {
+        unit: egui::MouseWheelUnit::Page,
+        delta: egui::vec2(0.0, -1.0),
+        modifiers: egui::Modifiers::NONE,
+    });
+    harness.snapshot_app("check_focus_6");
+
+    // Double click the entity on the streams tree and see all views expand.
+    harness.streams_tree().hover_label("boxes3d");
+    harness.streams_tree().click_label("boxes3d");
+    harness.streams_tree().click_label("boxes3d");
+    harness.snapshot_app("check_focus_7");
+
+    // Scroll down to see the second view is entirely expanded.
+    harness.blueprint_tree().hover_label("3D view 1");
+    harness.event(egui::Event::MouseWheel {
+        unit: egui::MouseWheelUnit::Page,
+        delta: egui::vec2(0.0, -1.0),
+        modifiers: egui::Modifiers::NONE,
+    });
+    harness.snapshot_app("check_focus_8");
+}

tests/rust/re_integration_test/tests/check_focus_test.rs

@@ -11,6 +11,8 @@ use re_viewport_blueprint::ViewBlueprint;
 fn make_multi_view_test_harness<'a>() -> egui_kittest::Harness<'a, re_viewer::App> {
     let mut harness = viewer_test_utils::viewer_harness(&HarnessOptions {
         window_size: Some(egui::Vec2::new(1024.0, 1024.0)),
+        max_steps: Some(100), // Allow animations to finish
+        ..Default::default()
     });
     harness.init_recording();