Skip to content

Commit 7c3cb99

Browse files
nojafnojaf
authored
Merge pull request #90 from rescript-lang/draw-image
Rename drawImage overloads
2 parents 36cb2d1 + aca7383 commit 7c3cb99

File tree

5 files changed

+30
-23
lines changed

5 files changed

+30
-23
lines changed

‎src/DOMAPI/CanvasRenderingContext2D.res‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ external drawImage: (
362362
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
363363
*/
364364
@send
365-
external drawImage2: (
365+
external drawImageWithSvg: (
366366
canvasRenderingContext2D,
367367
~image: svgImageElement,
368368
~dx: float,
@@ -373,7 +373,7 @@ external drawImage2: (
373373
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
374374
*/
375375
@send
376-
external drawImage3: (
376+
external drawImageWithVideo: (
377377
canvasRenderingContext2D,
378378
~image: htmlVideoElement,
379379
~dx: float,
@@ -384,7 +384,7 @@ external drawImage3: (
384384
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
385385
*/
386386
@send
387-
external drawImage4: (
387+
external drawImageWithCanvas: (
388388
canvasRenderingContext2D,
389389
~image: htmlCanvasElement,
390390
~dx: float,
@@ -395,7 +395,7 @@ external drawImage4: (
395395
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
396396
*/
397397
@send
398-
external drawImage5: (
398+
external drawImageWithImageBitmap: (
399399
canvasRenderingContext2D,
400400
~image: imageBitmap,
401401
~dx: float,
@@ -406,7 +406,7 @@ external drawImage5: (
406406
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
407407
*/
408408
@send
409-
external drawImage6: (
409+
external drawImageWithOffscreenCanvas: (
410410
canvasRenderingContext2D,
411411
~image: offscreenCanvas,
412412
~dx: float,
@@ -417,7 +417,7 @@ external drawImage6: (
417417
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
418418
*/
419419
@send
420-
external drawImage7: (
420+
external drawImageWithVideoFrame: (
421421
canvasRenderingContext2D,
422422
~image: videoFrame,
423423
~dx: float,
@@ -428,7 +428,7 @@ external drawImage7: (
428428
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
429429
*/
430430
@send
431-
external drawImage8: (
431+
external drawImageWithDimensions: (
432432
canvasRenderingContext2D,
433433
~image: htmlImageElement,
434434
~dx: float,
@@ -441,7 +441,7 @@ external drawImage8: (
441441
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
442442
*/
443443
@send
444-
external drawImage9: (
444+
external drawImageWithSvgDimensions: (
445445
canvasRenderingContext2D,
446446
~image: svgImageElement,
447447
~dx: float,
@@ -454,7 +454,7 @@ external drawImage9: (
454454
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
455455
*/
456456
@send
457-
external drawImage10: (
457+
external drawImageWithVideoDimensions: (
458458
canvasRenderingContext2D,
459459
~image: htmlVideoElement,
460460
~dx: float,
@@ -467,7 +467,7 @@ external drawImage10: (
467467
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
468468
*/
469469
@send
470-
external drawImage11: (
470+
external drawImageWithCanvasDimensions: (
471471
canvasRenderingContext2D,
472472
~image: htmlCanvasElement,
473473
~dx: float,
@@ -480,7 +480,7 @@ external drawImage11: (
480480
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
481481
*/
482482
@send
483-
external drawImage12: (
483+
external drawImageWithImageBitmapDimensions: (
484484
canvasRenderingContext2D,
485485
~image: imageBitmap,
486486
~dx: float,
@@ -493,7 +493,7 @@ external drawImage12: (
493493
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
494494
*/
495495
@send
496-
external drawImage13: (
496+
external drawImageWithOffscreenCanvasDimensions: (
497497
canvasRenderingContext2D,
498498
~image: offscreenCanvas,
499499
~dx: float,
@@ -506,7 +506,7 @@ external drawImage13: (
506506
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
507507
*/
508508
@send
509-
external drawImage14: (
509+
external drawImageWithVideoFrameDimensions: (
510510
canvasRenderingContext2D,
511511
~image: videoFrame,
512512
~dx: float,
@@ -519,7 +519,7 @@ external drawImage14: (
519519
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
520520
*/
521521
@send
522-
external drawImage15: (
522+
external drawImageWithSubRectangle: (
523523
canvasRenderingContext2D,
524524
~image: htmlImageElement,
525525
~sx: float,
@@ -536,7 +536,7 @@ external drawImage15: (
536536
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
537537
*/
538538
@send
539-
external drawImage16: (
539+
external drawImageWithSvgSubRectangle: (
540540
canvasRenderingContext2D,
541541
~image: svgImageElement,
542542
~sx: float,
@@ -553,7 +553,7 @@ external drawImage16: (
553553
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
554554
*/
555555
@send
556-
external drawImage17: (
556+
external drawImageWithVideoSubRectangle: (
557557
canvasRenderingContext2D,
558558
~image: htmlVideoElement,
559559
~sx: float,
@@ -570,7 +570,7 @@ external drawImage17: (
570570
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
571571
*/
572572
@send
573-
external drawImage18: (
573+
external drawImageWithCanvasSubRectangle: (
574574
canvasRenderingContext2D,
575575
~image: htmlCanvasElement,
576576
~sx: float,
@@ -587,7 +587,7 @@ external drawImage18: (
587587
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
588588
*/
589589
@send
590-
external drawImage19: (
590+
external drawImageWithImageBitmapSubRectangle: (
591591
canvasRenderingContext2D,
592592
~image: imageBitmap,
593593
~sx: float,
@@ -604,7 +604,7 @@ external drawImage19: (
604604
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
605605
*/
606606
@send
607-
external drawImage20: (
607+
external drawImageWithOffscreenCanvasSubRectangle: (
608608
canvasRenderingContext2D,
609609
~image: offscreenCanvas,
610610
~sx: float,
@@ -621,7 +621,7 @@ external drawImage20: (
621621
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D/drawImage)
622622
*/
623623
@send
624-
external drawImage21: (
624+
external drawImageWithVideoFrameSubRectangle: (
625625
canvasRenderingContext2D,
626626
~image: videoFrame,
627627
~sx: float,

‎src/DOMAPI/Document.res‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,7 @@ Creates an instance of the element for the specified tag.
155155
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/createElement)
156156
*/
157157
@send
158-
external createElement: (document, ~localName: string, ~options: string=?) => element =
159-
"createElement"
158+
external createElement: (document, string, ~options: string=?) => element = "createElement"
160159

161160
/**
162161
Creates an instance of the element for the specified tag.

‎tests/DOMAPI/HTMLCanvasElement__test.js‎

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎tests/DOMAPI/HTMLCanvasElement__test.res‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,6 @@ switch ctx.fillStyle->FillStyle.decode {
1717
| FillStyle.CanvasGradient(_) => Console.log("CanvasGradient")
1818
| FillStyle.CanvasPattern(_) => Console.log("CanvasPattern")
1919
}
20+
21+
let img: DOMAPI.htmlImageElement = document->Document.createElement("img")->Obj.magic
22+
ctx->CanvasRenderingContext2D.drawImageWithDimensions(~image=img, ~dx=0., ~dy=0., ~dw=200., ~dh=200.)

‎tests/DOMAPI/HTMLInputElement__test.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
open Global
22

33
let input: DOMAPI.htmlInputElement =
4-
document->Document.createElement(~localName="input")->Prelude.unsafeConversation
4+
document->Document.createElement("input")->Prelude.unsafeConversation
55
let value = input.value

0 commit comments

Comments
 (0)