Merge pull request #95 from rescript-lang/formdata-get

Improve Formdata overloads

Author: nojaf

src/FetchAPI/FormData.res

@@ -18,7 +18,7 @@ external append: (formData, ~name: string, ~value: string) => unit = "append"
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/append)
 */
 @send
-external append2: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit =
+external appendBlob: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit =
   "append"
 
 /**
@@ -31,13 +31,13 @@ external delete: (formData, string) => unit = "delete"
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/get)
 */
 @send
-external get: (formData, string) => file = "get"
+external get: (formData, string) => string = "get"
 
 /**
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/get)
 */
 @send
-external get2: (formData, string) => string = "get"
+external getFile: (formData, string) => file = "get"
 
 /**
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/getAll)
@@ -61,4 +61,4 @@ external set: (formData, ~name: string, ~value: string) => unit = "set"
 [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/set)
 */
 @send
-external set2: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit = "set"
+external setBlob: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit = "set"

tests/DOMAPI/HTMLCanvasElement__test.res

@@ -19,4 +19,10 @@ switch ctx.fillStyle->FillStyle.decode {
 }
 
 let img: DOMAPI.htmlImageElement = document->Document.createElement("img")->Obj.magic
-ctx->CanvasRenderingContext2D.drawImageWithDimensions(~image=img, ~dx=0., ~dy=0., ~dw=200., ~dh=200.)
+ctx->CanvasRenderingContext2D.drawImageWithDimensions(
+  ~image=img,
+  ~dx=0.,
+  ~dy=0.,
+  ~dw=200.,
+  ~dh=200.,
+)

tests/FetchAPI/FormData__test.js

@@ -0,0 +1,7 @@
+/* This works when your form has an id of "myForm" */
+@scope(("document", "forms"))
+external myForm: DOMAPI.htmlFormElement = "myForm"
+
+let formData = FormData.make(~form=myForm)
+let phone = formData->FormData.get("phone")
+let image = formData->FormData.getFile("image")