enable incremental typechecking by default

Author: zth

server/src/config.ts

@@ -17,7 +17,7 @@ export interface extensionConfiguration {
     forConstructorPayloads?: boolean;
   };
   incrementalTypechecking?: {
-    enabled?: boolean;
+    enable?: boolean;
     acrossFiles?: boolean;
     debugLogging?: boolean;
   };
@@ -46,7 +46,7 @@ let config: { extensionConfiguration: extensionConfiguration } = {
       forConstructorPayloads: true,
     },
     incrementalTypechecking: {
-      enabled: false,
+      enable: true,
       acrossFiles: false,
       debugLogging: false,
     },

server/src/server.ts

@@ -174,7 +174,7 @@ let deleteProjectDiagnostics = (projectRootPath: string) => {
     });
 
     projectsFiles.delete(projectRootPath);
-    if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
+    if (config.extensionConfiguration.incrementalTypechecking?.enable) {
       ic.removeIncrementalFileFolder(projectRootPath);
     }
   }
@@ -259,7 +259,7 @@ let openedFile = (fileUri: string, fileContent: string) => {
   if (projectRootPath != null) {
     let projectRootState = projectsFiles.get(projectRootPath);
     if (projectRootState == null) {
-      if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
+      if (config.extensionConfiguration.incrementalTypechecking?.enable) {
         ic.recreateIncrementalFileFolder(projectRootPath);
       }
       const namespaceName =
@@ -354,7 +354,7 @@ let openedFile = (fileUri: string, fileContent: string) => {
 let closedFile = (fileUri: string) => {
   let filePath = fileURLToPath(fileUri);
 
-  if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
+  if (config.extensionConfiguration.incrementalTypechecking?.enable) {
     ic.handleClosedFile(filePath);
   }
 
@@ -388,7 +388,7 @@ let updateOpenedFile = (fileUri: string, fileContent: string) => {
   let filePath = fileURLToPath(fileUri);
   assert(stupidFileContentCache.has(filePath));
   stupidFileContentCache.set(filePath, fileContent);
-  if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
+  if (config.extensionConfiguration.incrementalTypechecking?.enable) {
     ic.handleUpdateOpenedFile(filePath, fileContent, send, () => {
       if (config.extensionConfiguration.codeLens) {
         sendCodeLensRefresh();
@@ -862,7 +862,7 @@ function format(msg: p.RequestMessage): Array<p.Message> {
 }
 
 let updateDiagnosticSyntax = (fileUri: string, fileContent: string) => {
-  if (config.extensionConfiguration.incrementalTypechecking?.enabled) {
+  if (config.extensionConfiguration.incrementalTypechecking?.enable) {
     // The incremental typechecking already sends syntax diagnostics.
     return;
   }

server/src/utils.ts

@@ -224,7 +224,7 @@ export let runAnalysisAfterSanityCheck = (
       ...process.env,
       RESCRIPT_VERSION: rescriptVersion,
       RESCRIPT_INCREMENTAL_TYPECHECKING:
-        config.extensionConfiguration.incrementalTypechecking?.enabled === true
+        config.extensionConfiguration.incrementalTypechecking?.enable === true
           ? "true"
           : undefined,
       RESCRIPT_PROJECT_CONFIG_CACHE: