Async inline 2 (#5790)

* Prevent inlining of async functions in last stage of the compiler

* Update CHANGELOG.md

Fixes #5789

Author: cristianoc

CHANGELOG.md

@@ -10,6 +10,12 @@
 > - :house: [Internal]
 > - :nail_care: [Polish]
 
+# 10.1.0-rc.5
+
+#### :bug: Bug Fix
+
+- Prevent inlining of async functions in last stage of the compiler when the functions are not exported (not in interface file or shadowed) https://github.com/rescript-lang/rescript-compiler/pull/5790
+
 # 10.1.0-rc.4
 
 #### :rocket: New Feature

jscomp/core/js_pass_tailcall_inline.ml

@@ -165,7 +165,7 @@ let subst (export_set : Set_ident.t) stats =
                      Some
                        {
                          expression_desc =
-                           Fun {is_method=false; params; body; env};
+                           Fun {is_method=false; params; body; env; async=false};
                          comment = _;
                        };
                    (*TODO: don't inline method tail call yet,

jscomp/test/async_inline.js

@@ -1,5 +1,6 @@
 'use strict';
 
+var Curry = require("../../lib/js/curry.js");
 
 async function willBeInlined(param) {
   return 3;
@@ -14,7 +15,25 @@ function wrapSomethingAsync(param) {
         })(777));
 }
 
+async function doSomethingAsync(someAsyncFunction) {
+  return await Curry._1(someAsyncFunction, undefined);
+}
+
+var broken = doSomethingAsync;
+
+var M = {
+  broken: broken
+};
+
+async function broken$1(someAsyncFunction) {
+  return await Curry._1(someAsyncFunction, undefined);
+}
+
+var broken$2 = broken$1;
+
 exports.willBeInlined = willBeInlined;
 exports.inlined = inlined;
 exports.wrapSomethingAsync = wrapSomethingAsync;
+exports.M = M;
+exports.broken = broken$2;
 /* inlined Not a pure module */

jscomp/test/async_inline.res

@@ -9,4 +9,20 @@ let wrapSomethingAsync: unit => unit = () => {
       Js.log(test)
     }
   )(777)
-}
+}
+
+module M: {
+  let broken: (unit => promise<'a>) => promise<'a>
+} = {
+  let doSomethingAsync = async (someAsyncFunction) => {
+    await someAsyncFunction()
+  }
+
+  let broken = someAsyncFunction => doSomethingAsync(someAsyncFunction)
+}
+
+let broken = async (someAsyncFunction) => {
+  await someAsyncFunction()
+}
+
+let broken = someAsyncFunction => broken(someAsyncFunction)

lib/4.06.1/unstable/js_compiler.ml

@@ -92734,7 +92734,7 @@ let subst (export_set : Set_ident.t) stats =
                      Some
                        {
                          expression_desc =
-                           Fun {is_method=false; params; body; env};
+                           Fun {is_method=false; params; body; env; async=false};
                          comment = _;
                        };
                    (*TODO: don't inline method tail call yet,

lib/4.06.1/unstable/js_playground_compiler.ml

@@ -92734,7 +92734,7 @@ let subst (export_set : Set_ident.t) stats =
                      Some
                        {
                          expression_desc =
-                           Fun {is_method=false; params; body; env};
+                           Fun {is_method=false; params; body; env; async=false};
                          comment = _;
                        };
                    (*TODO: don't inline method tail call yet,

lib/4.06.1/whole_compiler.ml

@@ -262095,7 +262095,7 @@ let subst (export_set : Set_ident.t) stats =
                      Some
                        {
                          expression_desc =
-                           Fun {is_method=false; params; body; env};
+                           Fun {is_method=false; params; body; env; async=false};
                          comment = _;
                        };
                    (*TODO: don't inline method tail call yet,