Skip to content

Commit 9b341b6

Browse files
committed
Merge branch 'master' of github.com:rethinkdb/rethinkdb-python
2 parents 5350bca + 7753733 commit 9b341b6

File tree

5 files changed

+38
-7
lines changed

5 files changed

+38
-7
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ allow_failure:
1414

1515
install:
1616
- pip install -r requirements.txt
17+
- pip install -r requirements-dev.txt
1718

1819
before_script:
1920
- make prepare

requirements-dev.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
tornado>=5.0
2+
pytest-tornasync; python_version >= '3.5'

rethinkdb/tornado_net/net_tornado.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ def connect(self, timeout):
128128
self._stream = yield with_absolute_timeout(
129129
deadline,
130130
stream_future,
131-
io_loop=self._io_loop,
132131
quiet_exceptions=(iostream.StreamClosedError))
133132
except Exception as err:
134133
raise ReqlDriverError('Could not connect to %s:%s. Error: %s' %
@@ -152,7 +151,6 @@ def connect(self, timeout):
152151
response = yield with_absolute_timeout(
153152
deadline,
154153
self._stream.read_until(b'\0'),
155-
io_loop=self._io_loop,
156154
quiet_exceptions=(iostream.StreamClosedError))
157155
response = response[:-1]
158156
except ReqlAuthError:

tests/conftest.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import sys
22

33
collect_ignore = []
4-
if sys.version_info < (3, 4):
5-
collect_ignore += ["integration/test_asyncio.py", "integration/test_asyncio_coroutine.py"]
6-
elif sys.version_info < (3, 6):
7-
collect_ignore.append("integration/test_asyncio.py")
4+
85
if sys.version_info < (3, 6):
9-
collect_ignore.append("integration/test_trio.py")
6+
collect_ignore += [
7+
"integration/test_asyncio.py",
8+
"integration/test_asyncio_coroutine.py",
9+
"integration/test_tornado.py",
10+
"integration/test_trio.py",
11+
]
12+

tests/integration/test_tornado.py

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import os
2+
import sys
3+
from collections import namedtuple
4+
import pytest
5+
from rethinkdb import RethinkDB
6+
from rethinkdb.errors import ReqlRuntimeError
7+
8+
Helper = namedtuple("Helper", "r connection")
9+
10+
INTEGRATION_TEST_DB = 'integration_test'
11+
12+
13+
@pytest.mark.integration
14+
@pytest.mark.skipif(sys.version_info < (3, 6), reason="requires python3.6 or higher")
15+
async def test_tornado_connect(io_loop):
16+
"""
17+
Test the flow for 3.6 and up, async generators are
18+
not supported in 3.5.
19+
"""
20+
21+
r = RethinkDB()
22+
r.set_loop_type("tornado")
23+
24+
connection = await r.connect(os.getenv("REBIRTHDB_HOST"))
25+
dbs = await r.db_list().run(connection)
26+
assert isinstance(dbs, list)
27+
await connection.close()

0 commit comments

Comments
 (0)