Merge pull request #5289 from rmosolgo/test-helpers-authorize-dataloader

Fix run_graphql_field when .authorized? uses Dataloader

Author: rmosolgo

lib/graphql/testing/helpers.rb

@@ -43,18 +43,21 @@ def run_graphql_field(schema, field_path, object, arguments: {}, context: {}, as
         type_name, *field_names = field_path.split(".")
         dummy_query = GraphQL::Query.new(schema, "{ __typename }", context: context)
         query_context = dummy_query.context
+        dataloader = query_context.dataloader
         object_type = dummy_query.types.type(type_name) # rubocop:disable Development/ContextIsPassedCop
         if object_type
           graphql_result = object
           field_names.each do |field_name|
             inner_object = graphql_result
-            graphql_result = object_type.wrap(inner_object, query_context)
+            dataloader.run_isolated {
+              graphql_result = object_type.wrap(inner_object, query_context)
+            }
             if graphql_result.nil?
               return nil
             end
             visible_field = dummy_query.types.field(object_type, field_name) # rubocop:disable Development/ContextIsPassedCop
             if visible_field
-              dummy_query.context.dataloader.run_isolated {
+              dataloader.run_isolated {
                 query_context[:current_field] = visible_field
                 field_args = visible_field.coerce_arguments(graphql_result, arguments, query_context)
                 field_args = schema.sync_lazy(field_args)

spec/graphql/schema/field_spec.rb

@@ -836,6 +836,9 @@ def resolve
     # This is custom state added by some test schemas:
     custom_ivars = [:@upcase, :@future_schema, :@visible, :@allow_for, :@metadata, :@admin_only]
 
+    # Remove any invalid (non-retained) field instances from the heap
+    GC.start
+
     ObjectSpace.each_object(GraphQL::Schema::Field) do |field_obj|
       field_ivars = field_obj.instance_variables
       custom_ivars.each do |ivar|

spec/graphql/testing/helpers_spec.rb

@@ -81,6 +81,13 @@ def current_field
       end
     end
 
+    class AuthorizedObject < GraphQL::Schema::Object
+      def self.authorized?(object, context)
+        context.dataloader.with(BillSource).load(object)[:amount] > 5
+      end
+
+      field :id, ID
+    end
     class Query < GraphQL::Schema::Object
       field :students, [Student]
 
@@ -97,6 +104,8 @@ def student(student:)
       def lookahead_selections(lookahead:)
         lookahead.selections.to_s
       end
+
+      field :authorized_object, AuthorizedObject
     end
 
     query(Query)
@@ -199,6 +208,10 @@ def self.resolve_type(abs_t, obj, ctx)
         assert_equal "An instance of Hash failed AssertionsSchema::Student's authorization check on field ssn", err.message
       end
 
+      it "works when .authorized? calls dataloader" do
+        assert_equal "100", run_graphql_field(AssertionsSchema, "AuthorizedObject.id", { id: "100" })
+      end
+
       it "raises when the type doesn't exist" do
         err = assert_raises GraphQL::Testing::Helpers::TypeNotDefinedError do
           run_graphql_field(AssertionsSchema, "Nothing.nothing", :nothing)