CHECK Security/EscapeOutput: update for PHPCS 4.0

The tokenization of (namespaced) "names" has changed in PHP 8.0, and this new tokenization will come into effect for PHP_CodeSniffer as of version 4.0.0.

This commit adds handling for the new tokenization to this sniff.

Discuss if it is worth supporting `\true` and `\false` (and maybe even `\null`) in this sniff.

Author: rodrigoprimo

WordPress/Sniffs/Security/EscapeOutputSniff.php

@@ -187,6 +187,7 @@ public function process_token( $stackPtr ) {
 		$start = ( $stackPtr + 1 );
 
 		switch ( $this->tokens[ $stackPtr ]['code'] ) {
+			case \T_NAME_FULLY_QUALIFIED:
 			case \T_STRING:
 				// Prevent exclusion of any of the function groups.
 				$this->exclude = array();
@@ -575,9 +576,15 @@ protected function check_code_is_escaped( $start, $end, $code = 'OutputNotEscape
 				continue;
 			}
 
+			$content = $this->tokens[ $i ]['content'];
+
+			if ( \T_NAME_FULLY_QUALIFIED === $this->tokens[ $i ]['code'] ) {
+				$content = \ltrim( $content, '\\' );
+			}
+
 			// Ignore safe PHP native constants.
-			if ( \T_STRING === $this->tokens[ $i ]['code']
-				&& isset( $this->safe_php_constants[ $this->tokens[ $i ]['content'] ] )
+			if ( ( \T_STRING === $this->tokens[ $i ]['code'] || \T_NAME_FULLY_QUALIFIED === $this->tokens[ $i ]['code'] )
+				&& isset( $this->safe_php_constants[ $content ] )
 				&& ConstantsHelper::is_use_of_global_constant( $this->phpcsFile, $i )
 			) {
 				continue;
@@ -613,7 +620,7 @@ protected function check_code_is_escaped( $start, $end, $code = 'OutputNotEscape
 			}
 
 			// Check for use of *::class.
-			if ( \T_STRING === $this->tokens[ $i ]['code']
+			if ( isset( Collections::nameTokens()[ $this->tokens[ $i ]['code'] ] )
 				|| \T_VARIABLE === $this->tokens[ $i ]['code']
 				|| isset( Collections::ooHierarchyKeywords()[ $this->tokens[ $i ]['code'] ] )
 				|| \T_NAMESPACE === $this->tokens[ $i ]['code']
@@ -679,9 +686,9 @@ protected function check_code_is_escaped( $start, $end, $code = 'OutputNotEscape
 			}
 
 			// Now check that the next token is a function call.
-			if ( \T_STRING === $this->tokens[ $i ]['code'] ) {
+			if ( \T_STRING === $this->tokens[ $i ]['code'] || \T_NAME_FULLY_QUALIFIED === $this->tokens[ $i ]['code'] ) {
 				$ptr                    = $i;
-				$functionName           = $this->tokens[ $i ]['content'];
+				$functionName           = $content;
 				$function_opener        = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $i + 1 ), null, true );
 				$is_formatting_function = FormattingFunctionsHelper::is_formatting_function( $functionName );