Skip to content

Commit 5df05df

Browse files
authored
Revert spawner reordering (backport #547) (#966)
1 parent a1c6367 commit 5df05df

File tree

15 files changed

+81
-101
lines changed

15 files changed

+81
-101
lines changed

example_1/bringup/launch/rrbot.launch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,20 @@ def generate_launch_description():
108108
)
109109
)
110110

111-
# Delay start of joint_state_broadcaster after `robot_controller`
112-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
113-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
111+
# Delay start of robot_controller after `joint_state_broadcaster`
112+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
114113
event_handler=OnProcessExit(
115-
target_action=robot_controller_spawner,
116-
on_exit=[joint_state_broadcaster_spawner],
114+
target_action=joint_state_broadcaster_spawner,
115+
on_exit=[robot_controller_spawner],
117116
)
118117
)
119118

120119
nodes = [
121120
control_node,
122121
robot_state_pub_node,
123-
robot_controller_spawner,
122+
joint_state_broadcaster_spawner,
124123
delay_rviz_after_joint_state_broadcaster_spawner,
125-
delay_joint_state_broadcaster_after_robot_controller_spawner,
124+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
126125
]
127126

128127
return LaunchDescription(declared_arguments + nodes)

example_10/bringup/launch/rrbot.launch.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -96,27 +96,20 @@ def generate_launch_description():
9696
arguments=["gpio_controller", "-c", "/controller_manager"],
9797
)
9898

99-
# Delay start of joint_state_broadcaster after `robot_controller`
100-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
101-
delay_gpio_after_robot_controller_spawner = RegisterEventHandler(
99+
# Delay start of robot_controller after `joint_state_broadcaster`
100+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
102101
event_handler=OnProcessExit(
103-
target_action=robot_controller_spawner,
104-
on_exit=[gpio_controller_spawner],
105-
)
106-
)
107-
delay_joint_state_broadcaster_after_gpio_controller_spawner = RegisterEventHandler(
108-
event_handler=OnProcessExit(
109-
target_action=gpio_controller_spawner,
110-
on_exit=[joint_state_broadcaster_spawner],
102+
target_action=joint_state_broadcaster_spawner,
103+
on_exit=[robot_controller_spawner],
111104
)
112105
)
113106

114107
nodes = [
115108
control_node,
116109
robot_state_pub_node,
117-
robot_controller_spawner,
118-
delay_gpio_after_robot_controller_spawner,
119-
delay_joint_state_broadcaster_after_gpio_controller_spawner,
110+
joint_state_broadcaster_spawner,
111+
gpio_controller_spawner,
112+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
120113
]
121114

122115
return LaunchDescription(declared_arguments + nodes)

example_11/bringup/launch/carlikebot.launch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,22 +128,21 @@ def generate_launch_description():
128128
)
129129
)
130130

131-
# Delay start of joint_state_broadcaster after `robot_controller`
132-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
133-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
131+
# Delay start of robot_controller after `joint_state_broadcaster`
132+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
134133
event_handler=OnProcessExit(
135-
target_action=robot_bicycle_controller_spawner,
136-
on_exit=[joint_state_broadcaster_spawner],
134+
target_action=joint_state_broadcaster_spawner,
135+
on_exit=[robot_bicycle_controller_spawner],
137136
)
138137
)
139138

140139
nodes = [
141140
control_node,
142141
control_node_remapped,
143142
robot_state_pub_bicycle_node,
144-
robot_bicycle_controller_spawner,
145-
delay_joint_state_broadcaster_after_robot_controller_spawner,
143+
joint_state_broadcaster_spawner,
146144
delay_rviz_after_joint_state_broadcaster_spawner,
145+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
147146
]
148147

149148
return LaunchDescription(declared_arguments + nodes)

example_12/bringup/launch/rrbot.launch.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,22 +114,20 @@ def generate_launch_description():
114114
)
115115
)
116116

117-
# Delay start of joint_state_broadcaster after `robot_controller`
118-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
119-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
117+
# Delay start of robot_controller after `joint_state_broadcaster`
118+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
120119
event_handler=OnProcessExit(
121-
target_action=j1_controller_spawner,
122-
on_exit=[joint_state_broadcaster_spawner],
120+
target_action=joint_state_broadcaster_spawner,
121+
on_exit=[j1_controller_spawner, j2_controller_spawner],
123122
)
124123
)
125124

126125
nodes = [
127126
control_node,
128127
robot_state_pub_node,
129-
j1_controller_spawner,
130-
j2_controller_spawner,
128+
joint_state_broadcaster_spawner,
131129
delay_rviz_after_joint_state_broadcaster_spawner,
132-
delay_joint_state_broadcaster_after_robot_controller_spawner,
130+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
133131
]
134132

135133
return LaunchDescription(declared_arguments + nodes)

example_14/bringup/launch/rrbot_modular_actuators_without_feedback_sensors_for_position_feedback.launch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,21 +137,20 @@ def generate_launch_description():
137137
)
138138
)
139139

140-
# Delay start of joint_state_broadcaster after `robot_controller`
141-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
142-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
140+
# Delay start of robot_controller after `joint_state_broadcaster`
141+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
143142
event_handler=OnProcessExit(
144-
target_action=robot_controller_spawner,
145-
on_exit=[joint_state_broadcaster_spawner],
143+
target_action=joint_state_broadcaster_spawner,
144+
on_exit=[robot_controller_spawner],
146145
)
147146
)
148147

149148
nodes = [
150149
control_node,
151150
robot_state_pub_node,
152-
robot_controller_spawner,
151+
joint_state_broadcaster_spawner,
153152
delay_rviz_after_joint_state_broadcaster_spawner,
154-
delay_joint_state_broadcaster_after_robot_controller_spawner,
153+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
155154
]
156155

157156
return LaunchDescription(declared_arguments + nodes)

example_15/bringup/launch/rrbot_base.launch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,9 @@ def generate_launch_description():
223223
nodes = [
224224
control_node,
225225
robot_state_pub_node,
226-
robot_controller_spawner,
227226
joint_state_broadcaster_spawner,
228227
delay_rviz_after_joint_state_broadcaster_spawner,
228+
robot_controller_spawner,
229229
]
230230

231231
return LaunchDescription(declared_arguments + nodes)

example_15/bringup/launch/rrbot_namespace.launch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ def generate_launch_description():
131131
nodes = [
132132
control_node,
133133
robot_state_pub_node,
134+
joint_state_broadcaster_spawner,
134135
delay_rviz_after_joint_state_broadcaster_spawner,
135136
robot_forward_position_controller_spawner,
136-
joint_state_broadcaster_spawner,
137137
robot_position_trajectory_controller_spawner,
138138
]
139139

example_2/bringup/launch/diffbot.launch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,21 +115,20 @@ def generate_launch_description():
115115
)
116116
)
117117

118-
# Delay start of joint_state_broadcaster after `robot_controller`
119-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
120-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
118+
# Delay start of robot_controller after `joint_state_broadcaster`
119+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
121120
event_handler=OnProcessExit(
122-
target_action=robot_controller_spawner,
123-
on_exit=[joint_state_broadcaster_spawner],
121+
target_action=joint_state_broadcaster_spawner,
122+
on_exit=[robot_controller_spawner],
124123
)
125124
)
126125

127126
nodes = [
128127
control_node,
129128
robot_state_pub_node,
130-
robot_controller_spawner,
129+
joint_state_broadcaster_spawner,
131130
delay_rviz_after_joint_state_broadcaster_spawner,
132-
delay_joint_state_broadcaster_after_robot_controller_spawner,
131+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
133132
]
134133

135134
return LaunchDescription(declared_arguments + nodes)

example_3/bringup/launch/rrbot_system_multi_interface.launch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -160,21 +160,20 @@ def generate_launch_description():
160160
)
161161
)
162162

163-
# Delay start of joint_state_broadcaster after `robot_controller`
164-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
165-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
163+
# Delay start of robot_controller after `joint_state_broadcaster`
164+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
166165
event_handler=OnProcessExit(
167-
target_action=robot_controller_spawner,
168-
on_exit=[joint_state_broadcaster_spawner],
166+
target_action=joint_state_broadcaster_spawner,
167+
on_exit=[robot_controller_spawner],
169168
)
170169
)
171170

172171
nodes = [
173172
control_node,
174173
robot_state_pub_node,
175-
robot_controller_spawner,
174+
joint_state_broadcaster_spawner,
176175
delay_rviz_after_joint_state_broadcaster_spawner,
177-
delay_joint_state_broadcaster_after_robot_controller_spawner,
176+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
178177
]
179178

180179
return LaunchDescription(declared_arguments + nodes)

example_4/bringup/launch/rrbot_system_with_sensor.launch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -159,21 +159,20 @@ def generate_launch_description():
159159
)
160160
)
161161

162-
# Delay start of joint_state_broadcaster after `robot_controller`
163-
# TODO(anyone): This is a workaround for flaky tests. Remove when fixed.
164-
delay_joint_state_broadcaster_after_robot_controller_spawner = RegisterEventHandler(
162+
# Delay start of robot_controller after `joint_state_broadcaster`
163+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner = RegisterEventHandler(
165164
event_handler=OnProcessExit(
166-
target_action=robot_controller_spawner,
167-
on_exit=[joint_state_broadcaster_spawner],
165+
target_action=joint_state_broadcaster_spawner,
166+
on_exit=[robot_controller_spawner],
168167
)
169168
)
170169

171170
nodes = [
172171
control_node,
173172
robot_state_pub_node,
174-
robot_controller_spawner,
173+
joint_state_broadcaster_spawner,
175174
delay_rviz_after_joint_state_broadcaster_spawner,
176-
delay_joint_state_broadcaster_after_robot_controller_spawner,
175+
delay_robot_controller_spawner_after_joint_state_broadcaster_spawner,
177176
fts_broadcaster_spawner,
178177
]
179178

0 commit comments

Comments
 (0)