Merge pull request #9 from rpearce/change-default-element

Change default element from div to span

Author: rpearce

docs/app.js

@@ -23757,7 +23757,7 @@ function (_PureComponent) {
 
 exports.ButtonA11y = ButtonA11y;
 ButtonA11y.defaultProps = {
-  element: 'div',
+  element: 'span',
   onClick: Function.prototype,
   onKeyDown: Function.prototype,
   strictMode: true

source/index.js

@@ -45,7 +45,7 @@ export class ButtonA11y extends PureComponent {
 }
 
 ButtonA11y.defaultProps = {
-  element: 'div',
+  element: 'span',
   onClick: Function.prototype,
   onKeyDown: Function.prototype,
   strictMode: true

test/__snapshots__/index.test.js.snap

@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`ButtonA11y component renders, children 1`] = `
-<div
+<span
   aria-label="Mock Label"
   className="mock-className"
   onClick={[MockFunction]}
@@ -10,11 +10,11 @@ exports[`ButtonA11y component renders, children 1`] = `
   tabIndex="0"
 >
   Click me
-</div>
+</span>
 `;
 
 exports[`ButtonA11y component renders, no children 1`] = `
-<div
+<span
   aria-label="Mock Label"
   className="mock-className"
   onClick={[MockFunction]}
@@ -28,10 +28,10 @@ exports[`ButtonA11y component renders, ref passed in 1`] = `
 <ButtonA11y
   aria-label="Mock Label"
   className="mock-className"
-  element="div"
+  element="span"
   forwardedRef={
     Object {
-      "current": <div
+      "current": <span
         aria-label="Mock Label"
         class="mock-className"
         role="button"
@@ -43,7 +43,7 @@ exports[`ButtonA11y component renders, ref passed in 1`] = `
   onKeyDown={[Function]}
   strictMode={true}
 >
-  <div
+  <span
     aria-label="Mock Label"
     className="mock-className"
     onClick={[MockFunction]}
@@ -66,7 +66,7 @@ exports[`ButtonA11y component renders, span element 1`] = `
 `;
 
 exports[`ButtonA11y component renders, strict mode disabled 1`] = `
-<div
+<span
   aria-label="Mock Label"
   className="mock-className"
   onClick={[MockFunction]}
@@ -80,7 +80,7 @@ exports[`ButtonA11y container renders 1`] = `
 <ButtonA11y
   aria-label="Mock Label"
   className="mock-className"
-  element="div"
+  element="span"
   forwardedRef={null}
   onClick={[MockFunction]}
   onKeyDown={[Function]}

test/index.test.js

@@ -31,7 +31,7 @@ describe('ButtonA11y', () => {
           ref={ref}
         />
       )
-      expect(ref.current).toBeInstanceOf(HTMLDivElement)
+      expect(ref.current).toBeInstanceOf(HTMLSpanElement)
     })
 
   })