Skip to content

Commit 84af160

Browse files
authored
Adapts to ObservationConvention location change (#1071)
1 parent 04243e9 commit 84af160

File tree

4 files changed

+27
-14
lines changed

4 files changed

+27
-14
lines changed

rsocket-examples/src/test/java/io/rsocket/integration/observation/ObservationIntegrationTest.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class ObservationIntegrationTest extends SampleTestRunner {
6969
private final RSocketInterceptor responderInterceptor;
7070

7171
ObservationIntegrationTest() {
72-
super(SampleRunnerConfig.builder().build(), observationRegistry, registry);
72+
super(SampleRunnerConfig.builder().build());
7373
requesterInterceptor =
7474
reactiveSocket -> new ObservationRequesterRSocketProxy(reactiveSocket, observationRegistry);
7575

@@ -233,4 +233,14 @@ public Mono<Void> fireAndForget(Payload payload) {
233233
// @formatter:on
234234
};
235235
}
236+
237+
@Override
238+
protected MeterRegistry getMeterRegistry() {
239+
return registry;
240+
}
241+
242+
@Override
243+
protected ObservationRegistry getObservationRegistry() {
244+
return observationRegistry;
245+
}
236246
}

rsocket-micrometer/src/main/java/io/rsocket/micrometer/observation/RSocketDocumentedObservation.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,15 @@
1818

1919
import io.micrometer.common.docs.KeyName;
2020
import io.micrometer.observation.Observation;
21+
import io.micrometer.observation.ObservationConvention;
2122
import io.micrometer.observation.docs.DocumentedObservation;
2223

2324
enum RSocketDocumentedObservation implements DocumentedObservation {
2425

2526
/** Observation created on the RSocket responder side. */
2627
RSOCKET_RESPONDER {
2728
@Override
28-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
29+
public Class<? extends ObservationConvention<? extends Observation.Context>>
2930
getDefaultConvention() {
3031
return DefaultRSocketResponderObservationConvention.class;
3132
}
@@ -34,7 +35,7 @@ enum RSocketDocumentedObservation implements DocumentedObservation {
3435
/** Observation created on the RSocket requester side for Fire and Forget frame type. */
3536
RSOCKET_REQUESTER_FNF {
3637
@Override
37-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
38+
public Class<? extends ObservationConvention<? extends Observation.Context>>
3839
getDefaultConvention() {
3940
return DefaultRSocketRequesterObservationConvention.class;
4041
}
@@ -53,7 +54,7 @@ public String getPrefix() {
5354
/** Observation created on the RSocket responder side for Fire and Forget frame type. */
5455
RSOCKET_RESPONDER_FNF {
5556
@Override
56-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
57+
public Class<? extends ObservationConvention<? extends Observation.Context>>
5758
getDefaultConvention() {
5859
return DefaultRSocketResponderObservationConvention.class;
5960
}
@@ -72,7 +73,7 @@ public String getPrefix() {
7273
/** Observation created on the RSocket requester side for Request Response frame type. */
7374
RSOCKET_REQUESTER_REQUEST_RESPONSE {
7475
@Override
75-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
76+
public Class<? extends ObservationConvention<? extends Observation.Context>>
7677
getDefaultConvention() {
7778
return DefaultRSocketRequesterObservationConvention.class;
7879
}
@@ -91,7 +92,7 @@ public String getPrefix() {
9192
/** Observation created on the RSocket responder side for Request Response frame type. */
9293
RSOCKET_RESPONDER_REQUEST_RESPONSE {
9394
@Override
94-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
95+
public Class<? extends ObservationConvention<? extends Observation.Context>>
9596
getDefaultConvention() {
9697
return DefaultRSocketResponderObservationConvention.class;
9798
}
@@ -110,7 +111,7 @@ public String getPrefix() {
110111
/** Observation created on the RSocket requester side for Request Stream frame type. */
111112
RSOCKET_REQUESTER_REQUEST_STREAM {
112113
@Override
113-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
114+
public Class<? extends ObservationConvention<? extends Observation.Context>>
114115
getDefaultConvention() {
115116
return DefaultRSocketRequesterObservationConvention.class;
116117
}
@@ -129,7 +130,7 @@ public String getPrefix() {
129130
/** Observation created on the RSocket responder side for Request Stream frame type. */
130131
RSOCKET_RESPONDER_REQUEST_STREAM {
131132
@Override
132-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
133+
public Class<? extends ObservationConvention<? extends Observation.Context>>
133134
getDefaultConvention() {
134135
return DefaultRSocketResponderObservationConvention.class;
135136
}
@@ -148,7 +149,7 @@ public String getPrefix() {
148149
/** Observation created on the RSocket requester side for Request Channel frame type. */
149150
RSOCKET_REQUESTER_REQUEST_CHANNEL {
150151
@Override
151-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
152+
public Class<? extends ObservationConvention<? extends Observation.Context>>
152153
getDefaultConvention() {
153154
return DefaultRSocketRequesterObservationConvention.class;
154155
}
@@ -167,7 +168,7 @@ public String getPrefix() {
167168
/** Observation created on the RSocket responder side for Request Channel frame type. */
168169
RSOCKET_RESPONDER_REQUEST_CHANNEL {
169170
@Override
170-
public Class<? extends Observation.ObservationConvention<? extends Observation.Context>>
171+
public Class<? extends ObservationConvention<? extends Observation.Context>>
171172
getDefaultConvention() {
172173
return DefaultRSocketResponderObservationConvention.class;
173174
}

rsocket-micrometer/src/main/java/io/rsocket/micrometer/observation/RSocketRequesterObservationConvention.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@
1717
package io.rsocket.micrometer.observation;
1818

1919
import io.micrometer.observation.Observation;
20+
import io.micrometer.observation.ObservationConvention;
2021

2122
/**
22-
* {@link Observation.ObservationConvention} for RSocket requester {@link RSocketContext}.
23+
* {@link ObservationConvention} for RSocket requester {@link RSocketContext}.
2324
*
2425
* @author Marcin Grzejszczak
2526
* @since 2.0.0
2627
*/
2728
public interface RSocketRequesterObservationConvention
28-
extends Observation.ObservationConvention<RSocketContext> {
29+
extends ObservationConvention<RSocketContext> {
2930

3031
@Override
3132
default boolean supportsContext(Observation.Context context) {

rsocket-micrometer/src/main/java/io/rsocket/micrometer/observation/RSocketResponderObservationConvention.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@
1717
package io.rsocket.micrometer.observation;
1818

1919
import io.micrometer.observation.Observation;
20+
import io.micrometer.observation.ObservationConvention;
2021

2122
/**
22-
* {@link Observation.ObservationConvention} for RSocket responder {@link RSocketContext}.
23+
* {@link ObservationConvention} for RSocket responder {@link RSocketContext}.
2324
*
2425
* @author Marcin Grzejszczak
2526
* @since 2.0.0
2627
*/
2728
public interface RSocketResponderObservationConvention
28-
extends Observation.ObservationConvention<RSocketContext> {
29+
extends ObservationConvention<RSocketContext> {
2930

3031
@Override
3132
default boolean supportsContext(Observation.Context context) {

0 commit comments

Comments
 (0)