Skip to content

Commit da0c73f

Browse files
author
Oleh Dokuka
authored
enables previously disabled tests (#991)
Signed-off-by: Oleh Dokuka <shadowgun@i.ua> Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
1 parent d3ae6fa commit da0c73f

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

rsocket-core/src/test/java/io/rsocket/core/RSocketRequesterTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1201,7 +1201,6 @@ public void shouldTerminateAllStreamsIfThereRacingBetweenDisposeAndRequests(
12011201
}
12021202

12031203
@Test
1204-
@Disabled("Reactor 3.4.0 should fix that. No need to do anything on our side")
12051204
// see https://github.com/rsocket/rsocket-java/issues/858
12061205
public void testWorkaround858() {
12071206
ByteBuf buffer = rule.alloc().buffer();

rsocket-core/src/test/java/io/rsocket/core/RSocketResponderTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,9 @@ public Mono<Payload> requestResponse(Payload payload) {
167167

168168
@Test
169169
@Timeout(2_000)
170-
@Disabled
171170
public void testHandlerEmitsError() throws Exception {
172171
final int streamId = 4;
172+
rule.prefetch = 1;
173173
rule.sendRequest(streamId, FrameType.REQUEST_STREAM);
174174
assertThat(
175175
"Unexpected frame sent.", frameType(rule.connection.awaitFrame()), is(FrameType.ERROR));
@@ -839,7 +839,6 @@ private static Stream<FrameType> refCntCases() {
839839
}
840840

841841
@Test
842-
@Disabled("Reactor 3.4.0 should fix that. No need to do anything on our side")
843842
// see https://github.com/rsocket/rsocket-java/issues/858
844843
public void testWorkaround858() {
845844
ByteBuf buffer = rule.alloc().buffer();

rsocket-transport-netty/src/test/java/io/rsocket/transport/netty/server/CloseableChannelTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import static org.assertj.core.api.Assertions.assertThat;
2020
import static org.assertj.core.api.Assertions.assertThatNullPointerException;
2121

22-
import org.junit.jupiter.api.Disabled;
2322
import org.junit.jupiter.api.DisplayName;
2423
import org.junit.jupiter.api.Test;
2524
import reactor.core.publisher.Mono;
@@ -57,9 +56,6 @@ void constructorNullContext() {
5756
.withMessage("channel must not be null");
5857
}
5958

60-
@Disabled(
61-
"NettyContext isDisposed() is not accurate\n"
62-
+ "https://github.com/reactor/reactor-netty/issues/360")
6359
@DisplayName("disposes context")
6460
@Test
6561
void dispose() {

0 commit comments

Comments
 (0)