Cut 2.33.3

Author: koic

CHANGELOG.md

@@ -9,6 +9,8 @@
 
 ## master (unreleased)
 
+## 2.33.3 (2025-08-14)
+
 ### Bug fixes
 
 * [#1516](https://github.com/rubocop/rubocop-rails/pull/1516): Fix wrong autocorrect for `Rails/FindByOrAssignmentMemoization`. ([@earlopain][])

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop-rails
 title: RuboCop Rails
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: ~
+version: '2.33'
 nav:
   - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_rails.adoc

@@ -2637,7 +2637,7 @@ or the code may have a different purpose than memoization.
 
 [source,ruby]
 ----
-# bad
+# bad - exclusively doing memoization
 def current_user
   @current_user ||= User.find_by(id: session[:user_id])
 end
@@ -2648,6 +2648,22 @@ def current_user
 
   @current_user = User.find_by(id: session[:user_id])
 end
+
+# bad - method contains other code
+def current_user
+  @current_user ||= User.find_by(id: session[:user_id])
+  @current_user.do_something
+end
+
+# good
+def current_user
+  if defined?(@current_user)
+    @current_user
+  else
+    @current_user = User.find_by(id: session[:user_id])
+  end
+  @current_user.do_something
+end
 ----
 
 [#references-railsfindbyorassignmentmemoization]

lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.33.2'
+      STRING = '2.33.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

relnotes/v2.33.3.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#1516](https://github.com/rubocop/rubocop-rails/pull/1516): Fix wrong autocorrect for `Rails/FindByOrAssignmentMemoization`. ([@earlopain][])
+
+[@earlopain]: https://github.com/earlopain