fastly-invalidation: use explicit surrogate keys everywhere, remove magic

Author: syphar

src/cdn/fastly.rs

@@ -214,7 +214,7 @@ mod tests {
         let m = fastly_api
             .mock("POST", "/service/test-sid-1/purge")
             .match_header(FASTLY_KEY, "test-token")
-            .match_header(&SURROGATE_KEY, "crate-foo crate-bar")
+            .match_header(&SURROGATE_KEY, "crate-bar crate-foo")
             .with_status(200)
             .create_async()
             .await;
@@ -251,15 +251,15 @@ mod tests {
         let m1 = fastly_api
             .mock("POST", "/service/test-sid-1/purge")
             .match_header(FASTLY_KEY, "test-token")
-            .match_header(&SURROGATE_KEY, "crate-foo crate-bar")
+            .match_header(&SURROGATE_KEY, "crate-bar crate-foo")
             .with_status(200)
             .create_async()
             .await;
 
         let m2 = fastly_api
             .mock("POST", "/service/test-sid-2/purge")
             .match_header(FASTLY_KEY, "test-token")
-            .match_header(&SURROGATE_KEY, "crate-foo crate-bar")
+            .match_header(&SURROGATE_KEY, "crate-bar crate-foo")
             .with_status(200)
             .create_async()
             .await;
@@ -296,7 +296,7 @@ mod tests {
         let m = fastly_api
             .mock("POST", "/service/test-sid-1/purge")
             .match_header(FASTLY_KEY, "test-token")
-            .match_header(&SURROGATE_KEY, "crate-foo crate-bar")
+            .match_header(&SURROGATE_KEY, "crate-bar crate-foo")
             .with_status(500)
             .create_async()
             .await;

src/db/types/krate_name.rs

@@ -32,6 +32,12 @@ use std::{io::Write, str::FromStr};
 )]
 pub struct KrateName(String);
 
+impl From<&KrateName> for KrateName {
+    fn from(krate_name: &KrateName) -> Self {
+        krate_name.clone()
+    }
+}
+
 impl FromStr for KrateName {
     type Err = anyhow::Error;
 

src/lib.rs

@@ -1,6 +1,10 @@
 //! [Docs.rs](https://docs.rs) (formerly cratesfyi) is an open source project to host
 //! documentation of crates for the Rust Programming Language.
-#![allow(clippy::cognitive_complexity)]
+#![allow(
+    clippy::cognitive_complexity,
+    // TODO: `AxumNope::Redirect(EscapedURI, CachePolicy)` is too big.
+    clippy::result_large_err,
+)]
 
 pub use self::build_queue::{
     AsyncBuildQueue, BuildQueue, queue_rebuilds, queue_rebuilds_faulty_rustdoc,

src/test/mod.rs

@@ -18,7 +18,7 @@ use crate::{
     web::{
         build_axum_app,
         cache::{self, TargetCdn, X_RLNG_SOURCE_CDN},
-        headers::{IfNoneMatch, SURROGATE_CONTROL},
+        headers::{IfNoneMatch, SURROGATE_CONTROL, SurrogateKeys},
         page::TemplateData,
     },
 };
@@ -76,6 +76,11 @@ pub(crate) fn assert_cache_headers_eq(
         response.headers().get(&SURROGATE_CONTROL),
         "surrogate control header mismatch"
     );
+    assert_eq!(
+        expected_headers.surrogate_keys.as_ref(),
+        response.headers().typed_get::<SurrogateKeys>().as_ref(),
+        "surrogate key header mismatch"
+    );
 }
 
 pub(crate) trait AxumResponseTestExt {
@@ -113,7 +118,10 @@ impl AxumResponseTestExt for axum::response::Response {
         // we emit the wrong cache policy in a handler.
         //
         // The fastly specifics are tested in web::cache unittests.
-        assert_cache_headers_eq(self, &cache_policy.render(config, TargetCdn::Fastly));
+        assert_cache_headers_eq(
+            self,
+            &cache_policy.render(config, TargetCdn::Fastly).unwrap(),
+        );
     }
 
     fn error_for_status(self) -> Result<Self>

src/web/build_details.rs

@@ -73,13 +73,14 @@ pub(crate) async fn build_details_handler(
     let version = match_version(&mut conn, params.name(), params.req_version())
         .await?
         .assume_exact_name()?
-        .into_canonical_req_version_or_else(|version| {
+        .into_canonical_req_version_or_else(|confirmed_name, version| {
+            let params = params
+                .clone()
+                .with_confirmed_name(Some(confirmed_name))
+                .with_req_version(version);
             AxumNope::Redirect(
-                params
-                    .clone()
-                    .with_req_version(version)
-                    .build_details_url(id, build_params.filename.as_deref()),
-                CachePolicy::ForeverInCdn,
+                params.build_details_url(id, build_params.filename.as_deref()),
+                CachePolicy::ForeverInCdn(confirmed_name.into()),
             )
         })?
         .into_version();

src/web/builds.rs

@@ -67,10 +67,14 @@ pub(crate) async fn build_list_handler(
     let version = match_version(&mut conn, params.name(), params.req_version())
         .await?
         .assume_exact_name()?
-        .into_canonical_req_version_or_else(|version| {
+        .into_canonical_req_version_or_else(|confirmed_name, version| {
+            let params = params
+                .clone()
+                .with_confirmed_name(Some(confirmed_name))
+                .with_req_version(version);
             AxumNope::Redirect(
-                params.clone().with_req_version(version).builds_url(),
-                CachePolicy::ForeverInCdn,
+                params.builds_url(),
+                CachePolicy::ForeverInCdn(confirmed_name.into()),
             )
         })?
         .into_version();