Skip to content

Fix #24571: Handling nullable types in convertTo for adapting number constants to target number types #24580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

Fix #24571: Handling nullable types in convertTo for adapting number constants to target number types #24580

merged 1 commit into from
Nov 28, 2025
+26 −1

Conversation

@noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Nov 28, 2025

Fix #24571

@noti0na1 noti0na1 marked this pull request as ready for review November 28, 2025 15:41
hamzaremmal
hamzaremmal approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@hamzaremmal hamzaremmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't cover this case.

val x: Byte | String = 0

I'm accepting it because it fixes the regression in 3.8.0. But we should think of a more global design.

@hamzaremmal hamzaremmal added this to the 3.8.0 milestone Nov 28, 2025
@hamzaremmal hamzaremmal added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:command line Issues tied to how our launchers handle on the command line. and removed area:command line Issues tied to how our launchers handle on the command line. labels Nov 28, 2025
@noti0na1
Copy link
Member Author

noti0na1 commented Nov 28, 2025 •
edited
Loading

I will try a more general approach after 3.8.0

@noti0na1 noti0na1 merged commit 93408e8 into scala:main Nov 28, 2025
46 checks passed
@noti0na1 noti0na1 deleted the fix-24571 branch November 28, 2025 16:08
@hamzaremmal
Copy link
Member

hamzaremmal commented Nov 28, 2025 •
edited
Loading

I will try a more general approach after 3.8.0

This has to do with another can of worms we are trying to figure out. That's why I told you this morning it is not as simple as it looks to come up with a general solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

@olhotak olhotak Awaiting requested review from olhotak

Assignees

@hamzaremmal hamzaremmal

Labels

backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

Option.apply type inference

2 participants

@noti0na1 @hamzaremmal