Fix compatibility with latest version of scikit-learn (#131)

* change squared_loss to squared_error and fix check_is_fitted for fastfood

* fix squared_error retrocompatibility

* fix squared loss old version

* fix test squared error

* fix test squared error

* fix example clustering bandwidth

* Update sklearn_extra/robust/robust_weighted_estimator.py

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>

* change support python  and scikit-learn

* change support python scikit for mac and windows

* update requirements in README and doc

* Apply suggestions from code review

Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>

Co-authored-by: TMat <timothee.mathieu@inria.fr>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>

Author: TimotheeMathieu

README.rst

@@ -32,8 +32,8 @@ Dependencies
 
 scikit-learn-extra requires,
 
-- Python (>=3.6)
-- scikit-learn (>=0.23), and its dependencies
+- Python (>=3.7)
+- scikit-learn (>=0.24), and its dependencies
 
 
 Installation

azure-pipelines.yml

@@ -5,16 +5,11 @@ jobs:
     vmImage: 'ubuntu-latest'
   strategy:
     matrix:
-      Python36:
-        python.version: '3.6'
-        NUMPY_VERSION: "1.13.3"
-        SCIPY_VERSION: "0.19.1"
-        SKLEARN_VERSION: "0.23.0"
       Python37:
         python.version: '3.7'
         NUMPY_VERSION: "1.16.5"
         SCIPY_VERSION: "1.1.0"
-        SKLEARN_VERSION: "0.23.2"
+        SKLEARN_VERSION: "0.24.1"
       Python38:
         python.version: '3.8'
         NUMPY_VERSION: "1.19.4"
@@ -25,6 +20,12 @@ jobs:
         NUMPY_VERSION: "1.19.4"
         SCIPY_VERSION: "1.5.4"
         SKLEARN_VERSION: "nightly"
+      Py39_sklearn1:
+        python.version: '3.9'
+        NUMPY_VERSION: "1.19.4"
+        SCIPY_VERSION: "1.5.4"
+        SKLEARN_VERSION: "1.0.0"
+
   variables:
     OMP_NUM_THREADS: '2'
 
@@ -70,11 +71,6 @@ jobs:
     vmImage: 'macOS-10.14'
   strategy:
     matrix:
-      Python36:
-        python.version: '3.6'
-        NUMPY_VERSION: "1.13.3"
-        SCIPY_VERSION: "0.19.1"
-        SKLEARN_VERSION: "0.23.2"
       Python37:
         python.version: '3.7'
         NUMPY_VERSION: "1.16.5"
@@ -83,6 +79,11 @@ jobs:
       Python38:
         python.version: '3.8'
         SKLEARN_VERSION: "*"
+      Py39_sklearn1:
+        python.version: '3.9'
+        NUMPY_VERSION: "1.19.4"
+        SCIPY_VERSION: "1.5.4"
+        SKLEARN_VERSION: "1.0.0"
   variables:
     OMP_NUM_THREADS: '2'
 
@@ -126,18 +127,18 @@ jobs:
     vmImage: 'vs2017-win2016'
   strategy:
     matrix:
-      Python36:
-        python_ver: '36'
-        python.version: '3.6'
-        NUMPY_VERSION: "1.13.3"
-        SCIPY_VERSION: "1.0.1"
-        SKLEARN_VERSION: "0.23.2"
       Python38:
         python_ver: '38'
         python.version: '3.8'
         NUMPY_VERSION: "1.18.2"
         SCIPY_VERSION: "1.4.1"
         SKLEARN_VERSION: "0.24.1"
+      Py39_sklearn1:
+        python.version: '3.9'
+        NUMPY_VERSION: "1.19.4"
+        SCIPY_VERSION: "1.5.4"
+        SKLEARN_VERSION: "1.0.0"
+
   variables:
     OMP_NUM_THREADS: '2'
 

doc/install.rst

@@ -5,9 +5,9 @@ Dependencies
 ^^^^^^^^^^^^
 
 scikit-learn-extra requires,
- 
-- Python (>=3.6)
-- scikit-learn (>=0.23), and its dependencies
+
+- Python (>=3.7)
+- scikit-learn (>=0.24), and its dependencies
 
 
 User installation
@@ -22,7 +22,7 @@ Latest release can be installed with conda,
 or from PyPi with,
 
 .. code::
-   
+
    pip install scikit-learn-extra
 
 Latest development version can be installed with,

examples/cluster/plot_clustering.py

@@ -76,7 +76,7 @@
         k=int(n_samples / 20),
         random_state=rng,
     )
-    bandwidth = cluster.estimate_bandwidth(X, 0.2)
+    bandwidth = cluster.estimate_bandwidth(X, quantile=0.2)
 
     ms = cluster.MeanShift(bandwidth=bandwidth, bin_seeding=True)
 

sklearn_extra/kernel_approximation/_fastfood.py

@@ -201,6 +201,7 @@ def fit(self, X, y=None):
         )
 
         self._U = self._uniform_vector(rng)
+        self.is_fitted_ = True
 
         return self
 

sklearn_extra/robust/robust_weighted_estimator.py

@@ -49,12 +49,21 @@
 LOSS_FUNCTIONS = {
     "hinge": (Hinge,),
     "log": (Log,),
+    "squared_error": (SquaredLoss,),
     "squared_loss": (SquaredLoss,),
     "squared_hinge": (SquaredHinge,),
     "modified_huber": (ModifiedHuber,),
     "huber": (Huber, 1.35),  # 1.35 is default value. TODO : set as parameter
 }
 
+# Test version of sklearn, in version older than v1.0 squared_loss must be used
+import sklearn
+
+if sklearn.__version__[0] == "0":
+    SQ_LOSS = "squared_loss"
+else:
+    SQ_LOSS = "squared_error"
+
 
 def _huber_psisx(x, c):
     """Huber-loss weight for RobustWeightedEstimator algorithm"""
@@ -107,7 +116,7 @@ class _RobustWeightedEstimator(BaseEstimator):
         base_estimator.
         Classification losses supported : 'log', 'hinge', 'squared_hinge',
         'modified_huber'. If 'log', then the base_estimator must support
-        predict_proba. Regression losses supported : 'squared_loss', 'huber'.
+        predict_proba. Regression losses supported : 'squared_error', 'huber'.
         If callable, the function is used as loss function ro construct
         the weights.
 
@@ -270,7 +279,7 @@ def fit(self, X, y=None):
         if "warm_start" in parameters:
             base_estimator.set_params(warm_start=True)
 
-        if "loss" in parameters:
+        if ("loss" in parameters) and (loss_param != "squared_error"):
             base_estimator.set_params(loss=loss_param)
 
         if "eta0" in parameters:
@@ -971,8 +980,8 @@ class RobustWeightedRegressor(BaseEstimator, RegressorMixin):
         (using the inter-quartile range), this tends to be conservative
         (robust).
 
-    loss : string, None or callable, default="squared_loss"
-        For now, only "squared_loss" and "huber" are implemented.
+    loss : string, None or callable, default="squared_error"
+        For now, only "squared_error" and "huber" are implemented.
 
     sgd_args : dict, default={}
         arguments of the SGDClassifier base estimator.
@@ -1057,7 +1066,7 @@ def __init__(
         eta0=0.01,
         c=None,
         k=0,
-        loss="squared_loss",
+        loss=SQ_LOSS,
         sgd_args=None,
         tol=1e-3,
         n_iter_no_change=10,

sklearn_extra/robust/tests/test_robust_weighted_estimator.py

@@ -16,6 +16,13 @@
     assert_almost_equal,
 )
 
+# Test version of sklearn, in version older than v1.0 squared_loss must be used
+import sklearn
+
+if sklearn.__version__[0] == "0":
+    SQ_LOSS = "squared_loss"
+else:
+    SQ_LOSS = "squared_error"
 
 k_values = [None, 10]  # values of k for test robust
 c_values = [None, 1e-3]  # values of c for test robust
@@ -239,7 +246,7 @@ def test_robust_no_proba():
 X_rc = X_rc.reshape(-1, 1)
 y_rc[0] = -1
 
-regression_losses = ["squared_loss", "huber"]
+regression_losses = [SQ_LOSS, "huber"]
 
 
 @pytest.mark.parametrize("loss", regression_losses)