Merge branch 'master' into release/4

# Conflicts:
#	version

Author: host6

build.gradle

@@ -25,6 +25,14 @@ jacocoTestReport {
 	}
 }
 
+test {
+    testLogging {
+        events "failed"
+        exceptionFormat "full"
+    }
+}
+
+
 repositories {
 	maven { url "https://jitpack.io" }
 	mavenCentral()

src/main/java/org/scm4j/vcs/svn/SVNVCS.java

@@ -13,6 +13,7 @@
 import java.util.Set;
 
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.scm4j.vcs.api.IVCS;
 import org.scm4j.vcs.api.VCSChangeType;
 import org.scm4j.vcs.api.VCSCommit;
@@ -451,12 +452,16 @@ public List<VCSDiffEntry> getBranchesDiff(final String srcBranchName, final Stri
 	public Set<String> getBranches(String path) {
 		try {
 			List<String> entries = listEntries(SVNVCS.BRANCHES_PATH, path == null ? "" : path);
-			Set<String> res = new HashSet<>(entries);
+			Set<String> tempRes = new HashSet<>(entries);
 			if (repository.checkPath(MASTER_PATH, -1) == SVNNodeKind.DIR) {
 				if (path == null || MASTER_PATH.startsWith(path) ) {
-					res.add(MASTER_PATH.replace("/", ""));
+					tempRes.add(MASTER_PATH.replace("/", ""));
 				}
 			}
+			Set<String> res = new HashSet<>();
+			for (String str : tempRes) {
+				res.add(StringUtils.removeStart(str, SVNVCS.BRANCHES_PATH));
+			}
 			return res;
 		} catch (SVNException e) {
 			throw new EVCSException(e);
@@ -465,13 +470,13 @@ public Set<String> getBranches(String path) {
 		}
 	}
 
-	protected List<String> listEntries(String path, String subdir) throws Exception {
+	protected List<String> listEntries(String path, String subdirStartsWith) throws Exception {
 		List<String> res = new ArrayList<>();
-		if (repository.checkPath(path + subdir ,  -1) == SVNNodeKind.NONE) {
+		if (repository.checkPath(path ,  -1) == SVNNodeKind.NONE) {
 			return res;
 		}
 		@SuppressWarnings("unchecked")
-		Collection<SVNDirEntry> subEntries = repository.getDir(path + subdir, -1, null, (Collection<SVNDirEntry>) null);
+		Collection<SVNDirEntry> subEntries = repository.getDir(path, -1, null, (Collection<SVNDirEntry>) null);
 		List<SVNDirEntry> list = new ArrayList<>(subEntries);
 		Collections.sort(list, new Comparator<SVNDirEntry>() {
 			@Override
@@ -486,9 +491,8 @@ public int compare(SVNDirEntry o1, SVNDirEntry o2) {
 			}
 		});
 		for (SVNDirEntry entry : list) {
-			if (entry.getKind() == SVNNodeKind.DIR) {
-				res.add(((path.equals(SVNVCS.BRANCHES_PATH) ? "" : path) + subdir + entry.getName())
-						.replace(SVNVCS.BRANCHES_PATH, ""));
+			if (entry.getKind() == SVNNodeKind.DIR && entry.getName().startsWith(subdirStartsWith)) {
+				res.add(path + entry.getName());
 			}
 		}
 		return res;
@@ -634,21 +638,20 @@ public Boolean fileExists(String branchName, String filePath) {
 
 	@Override
 	public VCSTag createTag(String branchName, String tagName, String tagMessage, String revisionToTag) throws EVCSTagExists {
-		try {
+		try (IVCSLockedWorkingCopy wc = repo.getVCSLockedWorkingCopy()) {
 			SVNURL srcURL = getBranchUrl(branchName); 
 			SVNURL dstURL = SVNURL.parseURIEncoded(repoUrl + TAGS_PATH + tagName);
+			SVNLogEntry copyFromEntry = revToSVNEntry(getBranchName(branchName),
+					revisionToTag == null ? SVNRevision.HEAD.getNumber() : Long.parseLong(revisionToTag));
 			SVNCopySource copySource = revisionToTag == null ?
-					new SVNCopySource(SVNRevision.HEAD, SVNRevision.HEAD, srcURL) :
+					new SVNCopySource(SVNRevision.HEAD, SVNRevision.create(copyFromEntry.getRevision()), srcURL) :
 					new SVNCopySource(SVNRevision.parse(revisionToTag), SVNRevision.parse(revisionToTag), srcURL);
 
 			clientManager.getCopyClient().doCopy(new SVNCopySource[] {copySource}, dstURL, 
 			        false, false, true, tagMessage, null);
-			
+
 			SVNDirEntry entry = repository.info(TAGS_PATH + tagName, -1);
 
-			SVNLogEntry copyFromEntry = revToSVNEntry(getBranchName(branchName),
-					revisionToTag == null ? SVNRevision.HEAD.getNumber() : Long.parseLong(revisionToTag));
-			
 			return new VCSTag(tagName, tagMessage, entry.getAuthor(), svnLogEntryToVCSCommit(copyFromEntry));
 		} catch (SVNException e) {
 			if (e.getErrorMessage().getErrorCode().getCode() == SVN_ITEM_EXISTS_ERROR_CODE) {
@@ -691,10 +694,11 @@ public void handleLogEntry(SVNLogEntry logEntry) throws SVNException {
 	public List<VCSTag> getTags() {
 		try {
 			List<String> entries = listEntries(TAGS_PATH, "");
+			
 			List<VCSTag> res = new ArrayList<>();
 			SVNTagBaseCommit handler;
 			for (String entryStr : entries) {
-				
+
 				SVNLogEntry entry = revToSVNEntry(entryStr, -1L);
 
 				handler = new SVNTagBaseCommit();

src/test/java/org/scm4j/vcs/svn/SVNVCSTest.java

@@ -435,7 +435,7 @@ public void testSVNVCSUtilsCreation() {
 	public void testListEntriesNone() throws Exception {
 		SVNRepository mockedRepo = spy(svn.getSVNRepository());
 		svn.setSVNRepository(mockedRepo);
-		doReturn(SVNNodeKind.NONE).when(mockedRepo).checkPath(anyString(), anyLong());
+		doReturn(SVNNodeKind.NONE).when(mockedRepo).checkPath((String) isNull(), anyLong());
 		svn.listEntries(null, null); // expecting no NPE 
 	}
 }