Address review

Author: t1mlange

soot-infoflow/src/soot/jimple/infoflow/InfoflowConfiguration.java

@@ -1131,6 +1131,8 @@ public int hashCode() {
 			final int prime = 31;
 			int result = 1;
 			result = prime * result + ((dataFlowSolver == null) ? 0 : dataFlowSolver.hashCode());
+			if (dataFlowSolver == DataFlowSolver.SparseContextFlowSensitive)
+				result = prime * result + sparsePropagationStrategy.hashCode();
 			result = prime * result + maxCalleesPerCallSite;
 			result = prime * result + maxJoinPointAbstractions;
 			result = prime * result + maxAbstractionPathLength;
@@ -1148,6 +1150,9 @@ public boolean equals(Object obj) {
 			SolverConfiguration other = (SolverConfiguration) obj;
 			if (dataFlowSolver != other.dataFlowSolver)
 				return false;
+			if (dataFlowSolver == DataFlowSolver.SparseContextFlowSensitive)
+				if (sparsePropagationStrategy != other.sparsePropagationStrategy)
+					return false;
 			if (maxCalleesPerCallSite != other.maxCalleesPerCallSite)
 				return false;
 			if (maxJoinPointAbstractions != other.maxJoinPointAbstractions)

soot-infoflow/src/soot/jimple/infoflow/solver/sparseSolver/propagation/AbstractSparsePropagation.java

@@ -72,10 +72,13 @@ public boolean isAffectedBy(Unit unit) {
         protected boolean requiredForFlowSensitivity(Unit unit) {
             boolean forwardFlowSensitivity = activationUnit != null
                     && (activationUnit == unit || problem.isCallSiteActivatingTaint(unit, activationUnit));
+            if (forwardFlowSensitivity)
+                return true;
+
             SootMethod turnM;
             boolean backwardFlowSensitivity = turnUnit != null && (turnM = iCfg.getMethodOf(turnUnit)) != null
                     && (turnUnit == unit || iCfg.getCalleesOfCallAt(unit).stream().anyMatch(sm -> sm == turnM));
-            return forwardFlowSensitivity || backwardFlowSensitivity;
+            return backwardFlowSensitivity;
         }
 
         @Override

soot-infoflow/src/soot/jimple/infoflow/solver/sparseSolver/propagation/IPropagationStrategy.java

@@ -17,7 +17,7 @@ public interface IPropagationStrategy<N, D extends FastSolverLinkedNode<D, N>, I
     Collection<N> getSuccsOf(N n, D d);
 
     /**
-     * Get the successors of n given d
+     * Get the start points of sm given d
      *
      * @param sm method to be called
      * @param d  callee context abstraction