Skip to content

Commit 2850cad

Browse files
committed
fix long conversion issue
1 parent 633488e commit 2850cad

File tree

2 files changed

+5
-5
lines changed
  • analytics-kotlin-live/src

2 files changed

+5
-5
lines changed

analytics-kotlin-live/src/androidTest/java/com/segment/analytics/liveplugins/kotlin/JSStorageTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,16 +123,16 @@ class JSStorageTest {
123123
evaluate("""storage.getValue("long")""")
124124
}
125125
assertNull(exceptionThrown)
126-
assertEquals(1234567890123L, value)
127-
assertEquals(1234567890123L, jsStorage.getValue("long"))
126+
assertEquals(1234567890123L.toDouble(), value)
127+
assertEquals(1234567890123L.toDouble(), jsStorage.getValue("long"))
128128

129129
// set from native
130130
jsStorage.setValue("long", 9876543210987L)
131131
value = engine.await {
132132
evaluate("""storage.getValue("long")""")
133133
}
134-
assertEquals(9876543210987L, value)
135-
assertEquals(9876543210987L, jsStorage.getValue("long"))
134+
assertEquals(9876543210987L.toDouble(), value)
135+
assertEquals(9876543210987L.toDouble(), jsStorage.getValue("long"))
136136
}
137137

138138
@Test

analytics-kotlin-live/src/main/java/com/segment/analytics/liveplugins/kotlin/JSStorage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class JSStorage {
8080
TYPE_INT -> this.getInt(PROP_VALUE)
8181
TYPE_DOUBLE -> this.getDouble(PROP_VALUE)
8282
TYPE_STRING -> this.getString(PROP_VALUE)?.let { Json.decodeFromString<String>(it) }
83-
TYPE_LONG -> this.getLong(PROP_VALUE)
83+
TYPE_LONG -> this.getLong(PROP_VALUE)?.toDouble()
8484
else -> {
8585
this[PROP_VALUE]?.let {
8686
engine?.await {

0 commit comments

Comments
 (0)