Skip to content

Commit 0f8fcf6

Browse files
authored
Auto-load LivePlugins if DestinationFilters is added. (#17)
1 parent 63417c4 commit 0f8fcf6

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

.vscode/settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{}

Sources/AnalyticsLive/Filters/DestinationFilters.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,13 @@ public class DestinationFilters: UtilityPlugin {
7878

7979
public func configure(analytics: Analytics) {
8080
self.analytics = analytics
81-
81+
8282
if let e = analytics.find(pluginType: LivePlugins.self) {
8383
e.addDependent(plugin: self)
84+
} else {
85+
let e = LivePlugins(fallbackFileURL: nil)
86+
analytics.add(plugin: e)
87+
e.addDependent(plugin: self)
8488
}
8589
}
8690

Tests/AnalyticsLiveTests/Filters/AnalyticsFilters-Tests.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,15 @@ final class AnalyticsFilters_SwiftTests: XCTestCase {
3838

3939
analytics.add(plugin: inputReader)
4040

41-
analytics.add(plugin: LivePlugins(fallbackFileURL: nil))
41+
// Filters should add LivePlugins on its own.
42+
//analytics.add(plugin: LivePlugins(fallbackFileURL: nil))
4243
analytics.add(plugin: filters)
4344

4445
waitUntilStarted(analytics: analytics)
4546

47+
let e = analytics.find(pluginType: LivePlugins.self)
48+
XCTAssertTrue(e != nil)
49+
4650
analytics.track(name: "sampleEvent")
4751
RunLoop.main.run(until: Date.distantPast)
4852
let inputEvent: TrackEvent? = inputReader.lastEvent as? TrackEvent
Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
11
import XCTest
22
@testable import AnalyticsLive
33

4-
final class SignalsTests: XCTestCase {
5-
func testDebugCheck() {
6-
let debug = isAppRunningInDebug()
7-
XCTAssertTrue(debug)
8-
}
9-
}

0 commit comments

Comments
 (0)