Skip to content

Commit f898205

Browse files
committed
Added evaluator identification; Updated substrata.
1 parent a1d6b7a commit f898205

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

Package.resolved

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ let package = Package(
2121
// Dependencies declare other packages that this package depends on.
2222
.package(url: "https://github.com/segmentio/analytics-swift.git", from: "1.6.2"),
2323
//.package(path: "../analytics-swift"),
24-
.package(url: "https://github.com/segmentio/substrata-swift.git", from: "2.0.6")
24+
.package(url: "https://github.com/segmentio/substrata-swift.git", from: "2.0.8")
2525
],
2626
targets: [
2727
// Targets are the basic building blocks of a package, defining a module or a test suite.

Sources/AnalyticsLive/Filters/DestinationFilters.swift

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,14 @@ public class DestinationFilters: UtilityPlugin {
2828
}
2929
3030
execute(event) {
31+
if (event === null) return event;
3132
const result = dest_filters.evaluateDestinationFilters(this.rules, event);
32-
result.context.filterRan = true;
33-
console.log("filter applied");
33+
if (result === null) {
34+
console.log("filter dropped event");
35+
} else {
36+
result.context.filterRan = true;
37+
console.log("filter evaluated");
38+
}
3439
return result
3540
}
3641
}
@@ -54,6 +59,7 @@ public class DestinationFilters: UtilityPlugin {
5459
}
5560
5661
execute(event) {
62+
if (event === null) return event;
5763
const result = dest_filters.evaluateDestinationFilters(this.rules, event);
5864
return result
5965
}
@@ -104,8 +110,8 @@ extension DestinationFilters: LivePluginsDependent {
104110
public func prepare(engine: Substrata.JSEngine) {
105111
self.engine = engine
106112

107-
engine.evaluate(script: tsubScript)
108-
engine.evaluate(script: destinationFilterEdgeFunctionTypes)
113+
engine.evaluate(script: tsubScript, evaluator: "DestinationFilters.tsubScript")
114+
engine.evaluate(script: destinationFilterEdgeFunctionTypes, evaluator: "DestinationFilters.destinationFilterEdgeFunctionTypes")
109115
}
110116

111117
public func readyToStart() {

Sources/AnalyticsLive/LivePlugins/LivePlugins.swift

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,14 @@ extension LivePlugins {
112112
analyticsJS = a
113113

114114
// setup our embedded scripts ...
115-
engine.evaluate(script: EmbeddedJS.enumSetupScript)
116-
engine.evaluate(script: EmbeddedJS.edgeFnBaseSetupScript)
115+
engine.evaluate(script: EmbeddedJS.enumSetupScript, evaluator: "EmbeddedJS.enumSetupScript")
116+
engine.evaluate(script: EmbeddedJS.edgeFnBaseSetupScript, evaluator: "EmbeddedJS.edgeFnBaseSetupScript")
117117
}
118118

119119
internal func loadEdgeFn(url: URL) {
120120
// setup error handler
121121
engine.exceptionHandler = { error in
122-
// TODO: Make this useful
123-
print(error)
122+
print(error.string)
124123
}
125124

126125
var localURL = url

Sources/AnalyticsLive/Signals/AutoTracking/SwiftUI/Typealiases.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import Foundation
1313

1414
// Navigation
1515
typealias NavigationLink = SignalNavigationLink
16-
@available(iOS 16.0, *)
16+
@available(iOS 16.0, macOS 13.0, *)
1717
typealias NavigationStack = SignalNavigationStack
1818

1919
// Selection & Input Controls

Sources/AnalyticsLive/Signals/Signals.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ extension Signals {
162162
public func prepare(engine: JSEngine) {
163163
self.engine = engine
164164

165-
engine.evaluate(script: SignalsRuntime.embeddedJS)
165+
engine.evaluate(script: SignalsRuntime.embeddedJS, evaluator: "Signals.prepare")
166166

167167
#if os(iOS) || os(tvOS) || os(visionOS) || targetEnvironment(macCatalyst)
168168
if configuration.useUIKitAutoSignal {

0 commit comments

Comments
 (0)