Skip to content

Conversation

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Nov 16, 2025

Adding 2 new Actions and 5 presets to support Braze Ecommerce events.

Details in https://twilio-engineering.atlassian.net/browse/STRATCONN-6034

Testing

Unit tests added, and tested in Staging.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Braze Cloud Mode (Actions), Action Field(s):name,cancel_reason,time,checkout_id,order_id,cart_id,total_value,total_discounts,discounts,currency,source,enable_batching,batch_size,products
  • Destination: Braze Cloud Mode (Actions), Action Field(s):name,cancel_reason,time,checkout_id,order_id,cart_id,total_value,total_discounts,discounts,currency,source,enable_batching,batch_size,product

Add these new fields as optional instead and assume default values in perform or performBatch block.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.06%. Comparing base (fb8ca26) to head (98c34de).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ions/src/destinations/braze/ecommerce/functions.ts 75.53% 6 Missing and 17 partials ⚠️
...destinations/braze/ecommerceSingleProduct/index.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3417      +/-   ##
==========================================
+ Coverage   79.95%   80.06%   +0.10%     
==========================================
  Files        1222     1229       +7     
  Lines       22679    22841     +162     
  Branches     4501     4534      +33     
==========================================
+ Hits        18133    18287     +154     
+ Misses       3716     3706      -10     
- Partials      830      848      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants