curl: override any "-w" options that might exist

See the code comment for an explanation.

Author: kevinburkesegment

curl.go

@@ -96,7 +96,9 @@ func main() {
 }
 
 func run(ctx context.Context) error {
-	cArgs := make([]string, 0)
+	cArgs := []string{
+		"--header", "User-Agent: kubectl-curl",
+	}
 	flags.ParseAll(os.Args[1:], func(flag *pflag.Flag, value string) error {
 		if flag.Name == "silent" {
 			return nil // --silent is added later to all curl arguments so don't add here
@@ -239,7 +241,7 @@ func run(ctx context.Context) error {
 		}
 	}()
 
-	log.Printf("waiting for port fowarding to be established")
+	log.Printf("waiting for port forwarding to be established")
 	select {
 	case <-f.Ready:
 	case <-ctx.Done():
@@ -253,6 +255,11 @@ func run(ctx context.Context) error {
 	// print the dynamic progress view for the scenarios in which this
 	// plugin is useful for.
 	cArgs = append(cArgs, "--silent")
+	// Override any settings that users might have by default - for example,
+	// Kevin Burke has "-w \n" in his .curlrc file. Adding a new line to the end
+	// of the file is great for readability for most responses but breaks pprof
+	// and trace parsing.
+	cArgs = append(cArgs, "-w", "")
 
 	cmd := exec.CommandContext(ctx, "curl", cArgs...)
 	cmd.Stdin = os.Stdin