Update CDP Mode

Author: mdmintz

seleniumbase/core/sb_cdp.py

@@ -877,8 +877,13 @@ def set_value(self, selector, text, timeout=None):
 
     def evaluate(self, expression):
         """Run a JavaScript expression and return the result."""
-        if expression.startswith("return "):
-            expression = expression[len("return "):]
+        expression = expression.strip()
+        exp_list = expression.split("\n")
+        if exp_list and exp_list[-1].strip().startswith("return "):
+            expression = (
+                "\n".join(exp_list[0:-1]) + "\n"
+                + exp_list[-1].strip()[len("return "):]
+            ).strip()
         return self.loop.run_until_complete(
             self.page.evaluate(expression)
         )

seleniumbase/undetected/cdp_driver/cdp_util.py

@@ -241,7 +241,18 @@ async def start_async(*args, **kwargs) -> Browser:
 
 
 def start_sync(*args, **kwargs) -> Browser:
-    loop = asyncio.get_event_loop()
+    loop = None
+    if (
+        "loop" in kwargs
+        and kwargs["loop"]
+        and hasattr(kwargs["loop"], "create_task")
+    ):
+        loop = kwargs["loop"]
+    else:
+        try:
+            loop = asyncio.get_event_loop()
+        except RuntimeError:
+            loop = asyncio.new_event_loop()
     headless = False
     binary_location = None
     if "browser_executable_path" in kwargs:

seleniumbase/undetected/cdp_driver/tab.py

@@ -896,6 +896,10 @@ async def set_window_size(self, left=0, top=0, width=1280, height=1024):
         """
         return await self.set_window_state(left, top, width, height)
 
+    async def set_window_rect(self, left=0, top=0, width=1280, height=1024):
+        """Same as set_window_size(). Uses a different naming convention."""
+        return await self.set_window_state(left, top, width, height)
+
     async def activate(self):
         """Active this target (Eg: tab, window, page)"""
         await self.send(cdp.target.activate_target(self.target.target_id))