Use local mock server instead external ones

mcruzdev · mcruzdev · commit 1921a5e27b7e · 2025-11-26T22:59:22.000-03:00
Signed-off-by: Matheus Cruz &lt;matheuscruz.dev@gmail.com&gt;
diff --git a/impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/AbstractHttpExecutorBuilder.java b/impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/AbstractHttpExecutorBuilder.java
@@ -44,6 +44,9 @@ protected static RequestSupplier buildRequestSupplier(
         return new WithoutBodyRequestSupplier(Invocation.Builder::delete, application, redirect);
       case HttpMethod.HEAD:
         return new WithoutBodyRequestSupplier(Invocation.Builder::head, application, redirect);
+      case HttpMethod.PATCH:
+        return new WithBodyRequestSupplier(
+            (request, entity) -> request.method("PATCH", entity), application, body, redirect);
       case HttpMethod.OPTIONS:
         return new WithoutBodyRequestSupplier(Invocation.Builder::options, application, redirect);
       case HttpMethod.GET:
diff --git a/impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/AbstractRequestSupplier.java b/impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/AbstractRequestSupplier.java
@@ -40,11 +40,6 @@ public WorkflowModel apply(
       Builder request, WorkflowContext workflow, TaskContext task, WorkflowModel model) {
     HttpModelConverter converter = HttpConverterResolver.converter(workflow, task);
 
-    if (!redirect) {
-      // disable automatic redirects handling from Jersey client
-      request.property("jersey.config.client.followRedirects", false);
-    }
-
     Response response = invokeRequest(request, converter, workflow, task, model);
     validateStatus(task, response);
     return workflow
diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/HTTPWorkflowDefinitionTest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/HTTPWorkflowDefinitionTest.java
@@ -23,12 +23,14 @@
 import io.serverlessworkflow.impl.WorkflowApplication;
 import io.serverlessworkflow.impl.WorkflowModel;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.util.Map;
 import java.util.concurrent.CompletionException;
 import mockwebserver3.MockResponse;
 import mockwebserver3.MockWebServer;
+import mockwebserver3.RecordedRequest;
 import okhttp3.Headers;
-import org.assertj.core.api.Condition;
+import org.assertj.core.api.SoftAssertions;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
@@ -68,73 +70,204 @@ private static boolean httpCondition(WorkflowModel obj) {
 
   @Test
   void callHttpGet_should_return_pet_data() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            200,
+            Headers.of("Content-Type", "application/json"),
+            """
+            {
+                "petId": 10,
+                "photoUrls": [
+                    "https://example.com/photos/rex1.jpg",
+                    "https://example.com/photos/rex2.jpg"
+                ]
+            }
+            """));
     WorkflowModel result =
         appl.workflowDefinition(readWorkflowFromClasspath("workflows-samples/call-http-get.yaml"))
             .instance(Map.of("petId", 10))
             .start()
             .join();
-    assertThat(result)
-        .has(new Condition<>(HTTPWorkflowDefinitionTest::httpCondition, "callHttpCondition"));
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly
+              .assertThat(result.asMap().orElseThrow())
+              .containsKey("petId")
+              .containsKey("photoUrls");
+          try {
+            RecordedRequest recordedRequest = mockServer.takeRequest();
+            softly.assertThat(recordedRequest.getUrl()).asString().contains("/pets/10");
+            softly.assertThat(recordedRequest.getMethod()).isEqualTo("GET");
+          } catch (InterruptedException e) {
+            softly.fail(e);
+          }
+        });
   }
 
   @Test
   void callHttpGet_with_not_found_petId_should_keep_input_petId() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            404,
+            Headers.of("Content-Type", "application/json"),
+            """
+    {"message": "Pet not found"}
+    """));
     WorkflowModel result =
         appl.workflowDefinition(readWorkflowFromClasspath("workflows-samples/call-http-get.yaml"))
             .instance(Map.of("petId", "-1"))
             .start()
             .join();
-    assertThat(result.asMap().orElseThrow()).containsKey("petId");
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly.assertThat(result.asMap().orElseThrow()).containsKey("petId");
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("/pets/-1");
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("GET");
+        });
   }
 
   @Test
   void callHttpEndpointInterpolation_should_work() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            200,
+            Headers.of("Content-Type", "application/json"),
+            """
+            {
+                "petId": 1994,
+                "photoUrls": [
+                    "https://example.com/photos/dog1.jpg",
+                    "https://example.com/photos/dog2.jpg"
+                ]
+            }
+            """));
     WorkflowModel result =
         appl.workflowDefinition(
                 readWorkflowFromClasspath(
                     "workflows-samples/call-http-endpoint-interpolation.yaml"))
-            .instance(Map.of("petId", 10))
+            .instance(Map.of("petId", 1994))
             .start()
             .join();
-    assertThat(result)
-        .has(new Condition<>(HTTPWorkflowDefinitionTest::httpCondition, "callHttpCondition"));
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly
+              .assertThat(result.asMap().orElseThrow())
+              .containsKey("petId")
+              .containsKey("photoUrls");
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("/pets/1994");
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("GET");
+        });
   }
 
   @Test
   void callHttpQueryParameters_should_find_star_trek_movie() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            200,
+            Headers.of("Content-Type", "application/json"),
+            """
+            {
+                "movie": {
+                    "uid": "MOMA0000092393",
+                    "title": "Star Trek",
+                    "director": "J.J. Abrams"
+                }
+            }
+            """));
+
     WorkflowModel result =
         appl.workflowDefinition(
                 readWorkflowFromClasspath("workflows-samples/call-http-query-parameters.yaml"))
             .instance(Map.of("uid", "MOMA0000092393"))
             .start()
             .join();
-    assertThat(((Map<String, Object>) result.asMap().orElseThrow().get("movie")).get("title"))
-        .isEqualTo("Star Trek");
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          Map<String, Object> response = result.asMap().orElseThrow();
+          softly.assertThat(response).containsKey("movie");
+          var movie = (Map<String, Object>) response.get("movie");
+          softly.assertThat(movie).containsEntry("title", "Star Trek");
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("uid=MOMA0000092393");
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("GET");
+        });
   }
 
   @Test
   void callHttpFindByStatus_should_return_non_empty_collection() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            200,
+            Headers.of("Content-Type", "application/json"),
+            """
+            [
+                {
+                    "id": 1,
+                    "name": "Rex",
+                    "status": "sold"
+                },
+                {
+                    "id": 2,
+                    "name": "Fido",
+                    "status": "sold"
+                }
+            ]
+            """));
 
     WorkflowModel result =
         appl.workflowDefinition(
                 readWorkflowFromClasspath("workflows-samples/call-http-find-by-status.yaml"))
             .instance(Map.of())
             .start()
             .join();
-    assertThat(result.asCollection()).isNotEmpty();
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly.assertThat(result.asCollection()).isNotEmpty();
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("status=sold");
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("GET");
+        });
   }
 
   @Test
   void callHttpQueryParameters_external_schema_should_find_star_trek() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            200,
+            Headers.of("Content-Type", "application/json"),
+            """
+                      {
+                          "movie": {
+                              "uid": "MOMA0000092393",
+                              "title": "Star Trek",
+                              "director": "J.J. Abrams"
+                          }
+                      }
+                      """));
+
     WorkflowModel result =
         appl.workflowDefinition(
-                readWorkflowFromClasspath(
-                    "workflows-samples/call-http-query-parameters-external-schema.yaml"))
+                readWorkflowFromClasspath("workflows-samples/call-http-query-parameters.yaml"))
             .instance(Map.of("uid", "MOMA0000092393"))
             .start()
             .join();
-    assertThat(((Map<String, Object>) result.asMap().orElseThrow().get("movie")).get("title"))
-        .isEqualTo("Star Trek");
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          Map<String, Object> response = result.asMap().orElseThrow();
+          softly.assertThat(response).containsKey("movie");
+          var movie = (Map<String, Object>) response.get("movie");
+          softly.assertThat(movie).containsEntry("title", "Star Trek");
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("uid=MOMA0000092393");
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("GET");
+        });
   }
 
   @Test
@@ -144,38 +277,78 @@ void callHttpPost_should_return_created_firstName() throws Exception {
             200,
             Headers.of("Content-Type", "application/json"),
             """
-                                    {
-                                        "firstName": "Javierito"
-                                    }
-                                    """));
+                {
+                    "firstName": "Javierito"
+                }
+                """));
     WorkflowModel result =
         appl.workflowDefinition(readWorkflowFromClasspath("workflows-samples/call-http-post.yaml"))
             .instance(Map.of("name", "Javierito", "surname", "Unknown"))
             .start()
             .join();
-    assertThat(result.asText().orElseThrow()).isEqualTo("Javierito");
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly.assertThat(result.asText().orElseThrow()).isEqualTo("Javierito");
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("POST");
+          softly.assertThat(recordedRequest.getBody()).isNotNull();
+          softly
+              .assertThat(recordedRequest.getBody().string(StandardCharsets.UTF_8))
+              .contains("\"firstName\":\"Javierito\"")
+              .contains("\"lastName\":\"Unknown\"");
+        });
   }
 
   @Test
-  void testCallHttpDelete() {
-    assertDoesNotThrow(
-        () -> {
-          appl.workflowDefinition(
-                  readWorkflowFromClasspath("workflows-samples/call-http-delete.yaml"))
-              .instance(Map.of())
-              .start()
-              .join();
+  void testCallHttpDelete() throws IOException, InterruptedException {
+    mockServer.enqueue(new MockResponse(204, Headers.of(), ""));
+
+    WorkflowModel model =
+        appl.workflowDefinition(
+                readWorkflowFromClasspath("workflows-samples/call-http-delete.yaml"))
+            .instance(Map.of())
+            .start()
+            .join();
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly.assertThat(model).isNotNull();
+          softly.assertThat(recordedRequest.getMethod()).isEqualTo("DELETE");
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("/api/v1/authors/1");
         });
   }
 
   @Test
   void callHttpPut_should_contain_firstName_with_john() throws Exception {
+    mockServer.enqueue(
+        new MockResponse(
+            200,
+            Headers.of("Content-Type", "application/json"),
+            """
+            {
+                "id": 1,
+                "firstName": "John"
+            }
+            """));
+
     WorkflowModel result =
         appl.workflowDefinition(readWorkflowFromClasspath("workflows-samples/call-http-put.yaml"))
             .instance(Map.of("firstName", "John"))
             .start()
             .join();
-    assertThat(result.asText().orElseThrow()).contains("John");
+
+    RecordedRequest recordedRequest = mockServer.takeRequest();
+    SoftAssertions.assertSoftly(
+        softly -> {
+          softly.assertThat(result.asText().orElseThrow()).contains("John");
+          softly.assertThat(recordedRequest.getMethod()).contains("PUT");
+          softly
+              .assertThat(recordedRequest.getBody().string(StandardCharsets.UTF_8))
+              .contains("\"firstName\":\"John\"");
+          softly.assertThat(recordedRequest.getUrl()).asString().contains("api/v1/authors/1");
+        });
   }
 
   @Test
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-delete.yaml b/impl/test/src/test/resources/workflows-samples/call-http-delete.yaml
@@ -9,4 +9,4 @@ do:
       with:
         method: delete
         endpoint:
-          uri: https://fakerestapi.azurewebsites.net/api/v1/Authors/1
+          uri: https://localhost:9876/api/v1/authors/1
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-endpoint-interpolation.yaml b/impl/test/src/test/resources/workflows-samples/call-http-endpoint-interpolation.yaml
@@ -12,7 +12,7 @@ do:
             headers:
               content-type: application/json
             method: get
-            endpoint: ${ "https://petstore.swagger.io/v2/pet/\(.petId)" }
+            endpoint: ${ "http://localhost:9876/pets/\(.petId)" }
       catch:
         errors:
           with:
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-find-by-status.yaml b/impl/test/src/test/resources/workflows-samples/call-http-find-by-status.yaml
@@ -13,7 +13,7 @@ do:
                 content-type: application/json
               method: get
               endpoint: 
-                uri: https://petstore.swagger.io/v2/pet/findByStatus?status=sold
+                uri: http://localhost:9876/v2/pet/findByStatus?status=sold
       catch:
         errors:
           with:
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-get.yaml b/impl/test/src/test/resources/workflows-samples/call-http-get.yaml
@@ -13,7 +13,7 @@ do:
                 content-type: application/json
               method: get
               endpoint: 
-                uri: https://petstore.swagger.io/v2/pet/{petId}
+                uri: http://localhost:9876/pets/{petId}
       catch:
         errors:
           with:
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-patch.yaml b/impl/test/src/test/resources/workflows-samples/call-http-patch.yaml
@@ -0,0 +1,15 @@
+document:
+  dsl: 1.0.0-alpha1
+  namespace: test
+  name: call-http-patch
+  version: 1.0.0
+do:
+  - deleteAuthor:
+      call: http
+      with:
+        method: patch
+        endpoint:
+          uri: http://localhost:9876/users/1
+        headers:
+          Content-Type: application/json
+        body: "${{ newStatus: .status }}"
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-post.yaml b/impl/test/src/test/resources/workflows-samples/call-http-post.yaml
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-put.yaml b/impl/test/src/test/resources/workflows-samples/call-http-put.yaml
diff --git a/impl/test/src/test/resources/workflows-samples/call-http-query-parameters.yaml b/impl/test/src/test/resources/workflows-samples/call-http-query-parameters.yaml
