Skip to content

Commit 13449f0

Browse files
justin808claude
andcommitted
Migrate to modern ReScript .res.js suffix and remove patch
Following Alex Fedoseev's recommendation, migrated from .bs.js to .res.js suffix, eliminating the need for patching @glennsl/rescript-json-combinators. Changes: 1. Updated bsconfig.json suffix from .bs.js to .res.js 2. Removed patch for @glennsl/rescript-json-combinators 3. Updated webpack config to resolve .res.js extensions 4. Rebuilt ReScript - all files now generate with .res.js suffix 5. Removed duplicate RescriptShow/ror_components directory 6. Updated patches/README.md to document migration Why this is better: - ✅ No patch maintenance burden - ✅ Follows modern ReScript v11+ conventions (.bs being phased out) - ✅ Compatible with future ReScript versions - ✅ Works with all ReScript packages out of the box Upstream discussion: glennsl/rescript-json-combinators#9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 4d9d19e commit 13449f0

File tree

18 files changed

+771
-71
lines changed

18 files changed

+771
-71
lines changed

bsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
}
1414
],
1515
"bsc-flags": ["-open JsonCombinators", "-open Belt"],
16-
"suffix": ".bs.js",
16+
"suffix": ".res.js",
1717
"bs-dependencies": [
1818
"@rescript/react",
1919
"@rescript/core",

client/app/bundles/comments/rescript/Actions/Actions.res.js

Lines changed: 62 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/app/bundles/comments/rescript/CommentForm/CommentForm.res.js

Lines changed: 215 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/app/bundles/comments/rescript/CommentForm/forms/HorizontalForm.res.js

Lines changed: 77 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)