correct rubocop offenses after upgrading rails and rubocop

ihabadham · ihabadham · commit 2a896e8f10ae · 2024-12-16T04:34:31.000+02:00
This also fixes the CI Lint test failed first time
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb
@@ -50,8 +50,6 @@ def comments_json_string
   end
 
   def render_html
-    respond_to do |format|
-      format.html
-    end
+    respond_to(&:html)
   end
 end
diff --git a/config/application.rb b/config/application.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "boot"
 
 require "rails/all"
diff --git a/config/boot.rb b/config/boot.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
 
 require "bundler/setup" # Set up gems listed in the Gemfile.
diff --git a/config/environment.rb b/config/environment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
 require_relative "application"
 
diff --git a/config/environments/development.rb b/config/environments/development.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do
diff --git a/config/environments/production.rb b/config/environments/production.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do
@@ -34,8 +36,8 @@
   # config.ssl_options = { redirect: { exclude: ->(request) { request.path == "/up" } } }
 
   # Log to STDOUT with the current request id as a default log tag.
-  config.log_tags = [ :request_id ]
-  config.logger   = ActiveSupport::TaggedLogging.logger(STDOUT)
+  config.log_tags = [:request_id]
+  config.logger   = ActiveSupport::TaggedLogging.logger($stdout)
 
   # Change to "debug" to log everything (including potentially personally-identifiable information!)
   config.log_level = ENV.fetch("RAILS_LOG_LEVEL", "info")
@@ -76,7 +78,7 @@
   config.active_record.dump_schema_after_migration = false
 
   # Only use :id for inspections in production.
-  config.active_record.attributes_for_inspect = [ :id ]
+  config.active_record.attributes_for_inspect = [:id]
 
   # Enable DNS rebinding protection and other `Host` header attacks.
   # config.hosts = [
diff --git a/config/environments/test.rb b/config/environments/test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The test environment is used exclusively to run your application's
 # test suite. You never need to work with it otherwise. Remember that
 # your test database is "scratch space" for the test suite and is wiped
diff --git a/config/initializers/application_controller_renderer.rb b/config/initializers/application_controller_renderer.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # ActiveSupport::Reloader.to_prepare do
diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.
diff --git a/config/initializers/content_security_policy.rb b/config/initializers/content_security_policy.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide content security policy.
diff --git a/config/initializers/cors.rb b/config/initializers/cors.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Avoid CORS issues when API is called from the frontend app.
diff --git a/config/initializers/filter_parameter_logging.rb b/config/initializers/filter_parameter_logging.rb
@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure parameters to be partially matched (e.g. passw matches password) and filtered from the log file.
 # Use this to limit dissemination of sensitive information.
 # See the ActiveSupport::ParameterFilter documentation for supported notations and behaviors.
-Rails.application.config.filter_parameters += [
-  :passw, :email, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn, :cvv, :cvc
+Rails.application.config.filter_parameters += %i[
+  passw email secret token _key crypt salt certificate otp ssn cvv cvc
 ]
diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections
diff --git a/config/initializers/mime_types.rb b/config/initializers/mime_types.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:
diff --git a/config/initializers/new_framework_defaults_7_0.rb b/config/initializers/new_framework_defaults_7_0.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 #
 # This file eases your Rails 7.0 framework defaults upgrade.
diff --git a/config/initializers/new_framework_defaults_7_2.rb b/config/initializers/new_framework_defaults_7_2.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 #
 # This file eases your Rails 7.2 framework defaults upgrade.
diff --git a/config/initializers/new_framework_defaults_8_0.rb b/config/initializers/new_framework_defaults_8_0.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 #
 # This file eases your Rails 8.0 framework defaults upgrade.
diff --git a/config/initializers/permissions_policy.rb b/config/initializers/permissions_policy.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide HTTP permissions policy. For further
diff --git a/config/puma.rb b/config/puma.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This configuration file will be evaluated by Puma. The top-level methods that
 # are invoked here are part of Puma's configuration DSL. For more information
 # about methods provided by the DSL, see https://puma.io/puma/Puma/DSL.html.
diff --git a/lib/tasks/ci.rake b/lib/tasks/ci.rake
@@ -26,7 +26,7 @@ if Rails.env.development? || Rails.env.test?
       puts Rainbow("PASSED").green
       puts ""
     rescue StandardError => e
-      puts e.to_s
+      puts e
       puts Rainbow("FAILED").red
       puts ""
       raise(e)
@@ -38,7 +38,7 @@ if Rails.env.development? || Rails.env.test?
       puts Rainbow("PASSED").green
       puts ""
     rescue StandardError => e
-      puts e.to_s
+      puts e
       puts Rainbow("FAILED").red
       puts ""
       raise(e)
@@ -50,7 +50,7 @@ if Rails.env.development? || Rails.env.test?
       puts Rainbow("PASSED").green
       puts ""
     rescue StandardError => e
-      puts e.to_s
+      puts e
       puts Rainbow("FAILED").red
       puts ""
       raise(e)
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
@@ -44,7 +44,7 @@
   ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
 
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
-  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+  config.fixture_path = Rails.root.join("spec/fixtures")
 
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
diff --git a/spec/rescript/rescript_spec.rb b/spec/rescript/rescript_spec.rb
@@ -9,22 +9,23 @@
     end
 
     it "shows horizontal tab on visit" do
-      page.has_css?("form-horizontal")
+      expect(page).to have_css(".form-horizontal")
     end
 
     it "stops showing horizontal tab when other tab is clicked" do
-      find("button", text: "Inline Form")
-      page.has_no_css?("form-horizontal")
+      find("button", text: "Inline Form").click
+      expect(page).to have_no_css(".form-horizontal")
     end
 
     it "shows inline form when Inline Form link is clicked" do
-      find("button", text: "Inline Form", wait: 10)
-      page.has_css?("form-inline")
+      find("button", text: "Inline Form").click
+      expect(page).to have_css(".form-inline")
     end
 
     it "shows stacked form when Stacked Form link is clicked" do
-      find("button", text: "Stacked Form")
-      page.has_no_css?("form-inline") and page.has_no_css?("form-horizontal")
+      find("button", text: "Stacked Form").click
+      expect(page).to have_no_css(".form-inline")
+      expect(page).to have_no_css(".form-horizontal")
     end
   end
 
diff --git a/spec/stimulus/turbo_spec.rb b/spec/stimulus/turbo_spec.rb
@@ -9,22 +9,23 @@
     end
 
     it "shows horizontal tab on visit" do
-      page.has_css?("form-horizontal")
+      expect(page).to have_css(".form-horizontal")
     end
 
     it "stops showing horizontal tab when other tab is clicked" do
       click_link("Inline Form")
-      page.has_no_css?("form-horizontal")
+      expect(page).to have_no_css(".form-horizontal")
     end
 
     it "shows inline form when Inline Form link is clicked" do
       click_link("Inline Form")
-      page.has_css?("form-inline")
+      expect(page).to have_css(".form-inline")
     end
 
     it "shows stacked form when Stacked Form link is clicked" do
       click_link("Stacked Form")
-      page.has_no_css?("form-inline") and page.has_no_css?("form-horizontal")
+      expect(page).to have_no_css(".form-inline")
+      expect(page).to have_no_css(".form-horizontal")
     end
   end
 
diff --git a/spec/system/destroy_comment_spec.rb b/spec/system/destroy_comment_spec.rb
@@ -3,7 +3,7 @@
 require "rails_helper"
 require "system/shared/contexts"
 
-describe "Destroy a comment", existing_comment: true do
+describe "Destroy a comment", :existing_comment do
   context "when from classic page" do
     let(:comment) { build(:comment) }
 
diff --git a/spec/system/edit_comment_spec.rb b/spec/system/edit_comment_spec.rb
@@ -3,7 +3,7 @@
 require "rails_helper"
 require "system/shared/contexts"
 
-describe "Edit a comment", existing_comment: true do
+describe "Edit a comment", :existing_comment do
   let(:comment) { build(:comment) }
   let(:edited_name) { "Abraham Lincoln" }
 
@@ -20,7 +20,7 @@
       expect(page).to have_css("#notice", text: "Comment was successfully updated.")
     end
 
-    it "comment is not updated when edit is submitted with blank fields", blank_form_submitted: true do
+    it "comment is not updated when edit is submitted with blank fields", :blank_form_submitted do
       visit comments_path
       click_link "New Comment"
       submit_form

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require_relative "boot"`
`2`	`4`
`3`	`5`	`require "rails/all"`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# Load the Rails application.`
`2`	`4`	`require_relative "application"`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require "active_support/core_ext/integer/time"`
`2`	`4`
`3`	`5`	`Rails.application.configure do`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# The test environment is used exclusively to run your application's`
`2`	`4`	`# test suite. You never need to work with it otherwise. Remember that`
`3`	`5`	`# your test database is "scratch space" for the test suite and is wiped`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`# frozen_string_literal: true`
	`2`	`+`
`2`	`3`	`# Be sure to restart your server when you modify this file.`
`3`	`4`
`4`	`5`	`# ActiveSupport::Reloader.to_prepare do`