Skip to content

Commit c3ed3ac

Browse files
justin808claude
andcommitted
Improve test driver registration and sass configuration
- Apply consistent driver registration pattern across all drivers - Force re-register drivers to ensure fresh configuration in tests - Remove unnecessary empty includePaths from sass-loader options - Let Shakapacker handle default sass include paths These changes improve code consistency and prevent potential issues with overriding Shakapacker defaults. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 57bb979 commit c3ed3ac

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

config/webpack/commonWebpackConfig.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ if (sassLoaderIndex !== -1) {
4242
scssRule.use[sassLoaderIndex] = {
4343
loader: sassLoader,
4444
options: {
45-
api: 'modern',
46-
sassOptions: {
47-
includePaths: []
48-
}
45+
api: 'modern'
4946
}
5047
};
5148
} else {

spec/support/driver_registration.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,29 @@
22

33
module DriverRegistration
44
def self.register_selenium_chrome
5-
return if @selenium_chrome_registered
5+
# Force re-register to ensure our configuration is used
6+
Capybara.drivers.delete(:selenium_chrome)
67

78
Capybara.register_driver :selenium_chrome do |app|
89
Capybara::Selenium::Driver.new(app, browser: :chrome)
910
end
11+
1012
Capybara::Screenshot.register_driver(:selenium_chrome) do |js_driver, path|
1113
js_driver.browser.save_screenshot(path)
1214
end
13-
@selenium_chrome_registered = true
1415
end
1516

1617
def self.register_selenium_firefox
17-
return if @selenium_firefox_registered
18+
# Force re-register to ensure our configuration is used
19+
Capybara.drivers.delete(:selenium_firefox)
1820

1921
Capybara.register_driver :selenium_firefox do |app|
2022
Capybara::Selenium::Driver.new(app, browser: :firefox)
2123
end
24+
2225
Capybara::Screenshot.register_driver(:selenium_firefox) do |js_driver, path|
2326
js_driver.browser.save_screenshot(path)
2427
end
25-
@selenium_firefox_registered = true
2628
end
2729

2830
def self.register_selenium_chrome_headless

0 commit comments

Comments
 (0)