Skip to content

Commit 13a1aca

Browse files
justin808claude
andcommitted
Remove misleading TODO comment about shakapacker.yml integration
The TODO referenced automatic detection of server_bundle_output_path from shakapacker.yml, but this feature was never implemented and may not be feasible as originally conceived. Why this TODO is being removed: 1. The referenced feature/shakapacker-yml-integration branch did not contain the implementation - it only had the foundational work which was already merged via PRs #1798 and #1815 2. Shakapacker.yml's public_output_path serves a different purpose than React on Rails' server_bundle_output_path (public webpack output vs private server bundle security) 3. The current configuration approach is working well The server bundle security features (server_bundle_output_path and enforce_private_server_bundles) are fully implemented and tested on master. Closes #1808 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 15c7b5d commit 13a1aca

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lib/react_on_rails/configuration.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ def self.configuration
5151
server_bundle_output_path: "ssr-generated",
5252
enforce_private_server_bundles: false
5353
)
54-
# TODO: Add automatic detection of server_bundle_output_path from shakapacker.yml
55-
# See feature/shakapacker-yml-integration branch for implementation
56-
# Requires Shakapacker v8.5.0+ and semantic version checking
5754
end
5855

5956
class Configuration

0 commit comments

Comments
 (0)