Skip to content

Commit 2acff83

Browse files
justin808claude
andauthored
Skip flaky stream_async_components_for_testing RSpec test (#1941)
## Summary - Skip flaky `stream_async_components_for_testing` RSpec test that was replaced by Playwright E2E tests ## Details This test has been failing on master. Investigation revealed: 1. The test was already replaced by more reliable Playwright E2E tests in commit b73ff63 "Replace streaming flaky tests with Playwright E2E tests" (2 weeks ago) 2. The old RSpec tests were kept but are flaky and unreliable for testing streaming behavior 3. The Playwright tests in `e2e-tests/streaming.spec.ts` provide comprehensive coverage of the streaming functionality ## Test Coverage The removed RSpec test is fully covered by Playwright E2E tests which: - Test incremental rendering of streamed components - Test early hydration of pages - Test RSC payload requests - Provide snapshot-based verification of component states ## Related - Related commit: b73ff63 "Replace streaming flaky tests with Playwright E2E tests" - Similar approach used for "React Router Sixth Page" test which is also skipped 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/shakacode/react_on_rails/1941) <!-- Reviewable:end --> Co-authored-by: Claude <noreply@anthropic.com>
1 parent 23be9a9 commit 2acff83

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

react_on_rails_pro/spec/dummy/spec/system/integration_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,8 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
422422
end
423423
end
424424

425-
describe "Pages/stream_async_components_for_testing", :js do
425+
describe "Pages/stream_async_components_for_testing", :js,
426+
skip: "Flaky test replaced by Playwright E2E tests in e2e-tests/streaming.spec.ts" do
426427
it_behaves_like "streamed component tests", "/stream_async_components_for_testing",
427428
"#AsyncComponentsTreeForTesting-react-component-0"
428429
end

0 commit comments

Comments
 (0)