Skip to content

Commit 7b392db

Browse files
Romex91Judahmeek
authored andcommitted
address review issues
1 parent 03f9aa3 commit 7b392db

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,12 @@ Please follow the recommendations outlined at [keepachangelog.com](http://keepac
1818
### [Unreleased]
1919
Changes since the last non-beta release.
2020

21-
#### Fixed
21+
#### Breaking
2222
- Reduced bundle size [PR 1697](https://github.com/shakacode/react_on_rails/pull/1697) by [Romex91](https://github.com/Romex91)
23-
- Migrated from CJS to ESM for more compact modules (~1KB improvement)
23+
- Migrated from CJS to ESM for more compact modules (~1KB improvement). **Breaking change:** All dependencies running `require('react-on-rails')` will need to update to ESM `import ReactOnRails from 'react-on-rails'`.
2424
- Add export option 'react-on-rails/client' to avoid shipping server-rendering code to browsers (~14KB improvement).
25+
26+
#### Fixed
2527
- Fix obscure errors by introducing FULL_TEXT_ERRORS [PR 1695](https://github.com/shakacode/react_on_rails/pull/1695) by [Romex91](https://github.com/Romex91).
2628
- Disable `esModuleInterop` to increase interoperability [PR 1699](https://github.com/shakacode/react_on_rails/pull/1699) by [alexeyr-ci](https://github.com/alexeyr-ci).
2729
- Resolved 14.1.1 incompatibility with eslint & made sure that spec/dummy is linted by eslint. [PR 1693](https://github.com/shakacode/react_on_rails/pull/1693) by [judahmeek](https://github.com/judahmeek).

tsconfig.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
"esModuleInterop": false,
66
// needed for Jest tests even though we don't use .tsx
77
"jsx": "react-jsx",
8-
"lib": ["dom", "ESNext"],
9-
"module": "ESNext",
8+
"lib": ["dom", "es2015"],
9+
"module": "es2015",
1010
"moduleResolution": "bundler",
1111
"noImplicitAny": true,
1212
"outDir": "node_package/lib",
1313
"strict": true,
1414
"incremental": true,
15-
"target": "ESNext"
15+
"target": "es2015"
1616
},
1717
"include": ["node_package/src/**/*"]
1818
}

0 commit comments

Comments
 (0)