Skip to content

Commit bb71b1f

Browse files
justin808claude
andcommitted
Fix inverted matrix logic in CI workflows
CRITICAL FIX: The determine-matrix logic was backwards. Before: - master/force_run/full-ci → ["latest"] (only 1 config) - Regular PRs → ["latest","minimum"] (both configs) After (correct): - master/force_run/full-ci → ["latest","minimum"] (both configs) - Regular PRs → ["latest"] (only 1 config) This ensures: - PRs get fast feedback with latest dependencies only - Master and full CI runs test both latest AND minimum supported versions Affected workflows: - examples.yml - gem-tests.yml - integration-tests.yml - package-js-tests.yml 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 1c54be1 commit bb71b1f

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/examples.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ jobs:
4242
id: determine-matrix
4343
run: |
4444
if [ "${{ inputs.force_run }}" = "true" ] || [ "${{ steps.check-label.outputs.result }}" = "true" ] || [ "${{ github.ref }}" = "refs/heads/master" ]; then
45-
echo "result=[\"latest\"]" >> "$GITHUB_OUTPUT"
46-
else
4745
echo "result=[\"latest\",\"minimum\"]" >> "$GITHUB_OUTPUT"
46+
else
47+
echo "result=[\"latest\"]" >> "$GITHUB_OUTPUT"
4848
fi
4949
- name: Detect relevant changes
5050
id: detect

.github/workflows/gem-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ jobs:
4444
id: determine-matrix
4545
run: |
4646
if [ "${{ inputs.force_run }}" = "true" ] || [ "${{ steps.check-label.outputs.result }}" = "true" ] || [ "${{ github.ref }}" = "refs/heads/master" ]; then
47-
echo "result=[\"latest\"]" >> "$GITHUB_OUTPUT"
48-
else
4947
echo "result=[\"latest\",\"minimum\"]" >> "$GITHUB_OUTPUT"
48+
else
49+
echo "result=[\"latest\"]" >> "$GITHUB_OUTPUT"
5050
fi
5151
- name: Detect relevant changes
5252
id: detect

.github/workflows/integration-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ jobs:
4343
id: determine-matrix
4444
run: |
4545
if [ "${{ inputs.force_run }}" = "true" ] || [ "${{ steps.check-label.outputs.result }}" = "true" ] || [ "${{ github.ref }}" = "refs/heads/master" ]; then
46-
echo "result=[\"latest\"]" >> "$GITHUB_OUTPUT"
47-
else
4846
echo "result=[\"latest\",\"minimum\"]" >> "$GITHUB_OUTPUT"
47+
else
48+
echo "result=[\"latest\"]" >> "$GITHUB_OUTPUT"
4949
fi
5050
- name: Detect relevant changes
5151
id: detect

.github/workflows/package-js-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ jobs:
4545
id: determine-matrix
4646
run: |
4747
if [ "${{ inputs.force_run }}" = "true" ] || [ "${{ steps.check-label.outputs.result }}" = "true" ] || [ "${{ github.ref }}" = "refs/heads/master" ]; then
48-
echo "result=[\"22\"]" >> "$GITHUB_OUTPUT"
49-
else
5048
echo "result=[\"22\",\"20\"]" >> "$GITHUB_OUTPUT"
49+
else
50+
echo "result=[\"22\"]" >> "$GITHUB_OUTPUT"
5151
fi
5252
- name: Detect relevant changes
5353
id: detect

0 commit comments

Comments
 (0)