Phase 5: Add Pro Node Renderer Package to workspace (#2069)

### Summary

Completes Phase 5 of the monorepo migration by extracting the Pro
node-renderer package to the workspace structure. This establishes the
3-package NPM workspace and sets up proper workspace dependency
management.

### Changes Made

**Package Structure**
- Created `packages/react-on-rails-pro-node-renderer/` with package.json
and tsconfig.json
- Moved 72 files (29 src + 43 tests) with full git history preserved
- Updated root package.json workspaces to include 3rd NPM package

**Configuration Updates**
- Fixed .gitignore to track workspace source code (only ignore lib/
outputs)
- Updated LICENSE.md to include new package in Pro license section
- Updated root build script to compile all 3 packages

**Workspace Verification**
All 3 packages properly recognized:
- react-on-rails (no deps)
- react-on-rails-pro (depends on react-on-rails)  
- react-on-rails-pro-node-renderer (depends on both)

### Known Issues (Pre-Existing)

Node-renderer has TypeScript build errors that existed before this move:
- Missing .js extensions in ~30+ ESM imports
- Missing type declarations (fastify, @sentry/node, @honeybadger-io/js)
- Export format issues (export = vs export default)

These will be fixed in a separate follow-up PR. See
PHASE_5_COMPLETION_NOTES.md for details.

### Pull Request Checklist

- [x] Workspace structure properly configured
- [x] All 72 files moved with git history preserved
- [x] LICENSE.md updated with new package path
- [x] No pro code in MIT directories
- [x] Documentation created and updated
- [ ] Follow-up PR for TypeScript build errors

### Related

- Completes monorepo migration Phase 5
- Fixes YALC publish issue once TS errors are resolved
- Prepares for Phase 6 (Ruby gem restructuring)
- See PHASE_5_COMPLETION_NOTES.md for comprehensive summary

Author: justin808

AI_AGENT_INSTRUCTIONS.md renamed to .claude/docs/analysis/AI_AGENT_INSTRUCTIONS.md

@@ -0,0 +1,276 @@
+# React on Rails Monorepo Migration - Analysis Index
+
+This directory contains comprehensive analysis of the React on Rails monorepo migration status and recommendations.
+
+## Documents Overview
+
+### 1. CI_FAILURES_2024-11-21.md (CURRENT BLOCKER - 24 KB) 🔴
+
+**Critical CI failure analysis for justin808/monorepo-completion branch**
+
+**Status**: NOT READY TO MERGE - 3 failing test suites, 1 hung test
+
+Contains:
+
+- Executive summary of all test failures
+- Root cause analysis for each failure
+- Comparison with base commit (all tests passing)
+- Suspicious commits that likely introduced issues
+- Detailed debugging strategy and fix recommendations
+- Prevention strategies for future regressions
+
+**Use when**: Debugging current CI failures, planning fixes, understanding what broke
+
+---
+
+### 2. MONOREPO_MIGRATION_ANALYSIS.md (PRIMARY - 16 KB)
+
+**Comprehensive technical analysis of the entire monorepo migration**
+
+Contains 12 detailed sections:
+
+- Executive summary with current phase status
+- Directory structure analysis (current vs target)
+- YALC publishing configuration review
+- Build and package scripts examination
+- Documentation status
+- Migration TODOs and issues
+- CI/CD configuration analysis
+- What's working and what needs attention
+- Critical dependencies and interactions
+- Key files to monitor
+- Detailed next steps recommendations
+- Success criteria definition
+
+**Use when**: You need complete technical details, planning next phases, or understanding dependencies
+
+### 3. MIGRATION_QUICK_REFERENCE.md (REFERENCE - 6.8 KB)
+
+**Quick lookup guide with status dashboards and checklists**
+
+Contains:
+
+- Migration phase status overview
+- Directory structure comparison table
+- YALC workflow comparison
+- Path reference guide (CRITICAL)
+- Status tables for all components
+- Testing checklists
+- Common issues and solutions
+- Key metrics
+- Next actions breakdown
+
+**Use when**: You need quick answers, status updates, or testing guidance
+
+### 4. CLAUDE_MD_UPDATES.md (SUPPORTING - 11 KB)
+
+**Documentation of CLAUDE.md improvements for monorepo**
+
+Details improvements to project guidelines including:
+
+- Monorepo-specific development instructions
+- Workspace management guidance
+- Build and testing updates
+- CI configuration notes
+
+**Use when**: Learning about updated developer guidelines
+
+### 5. claude-md-improvements.md (SUPPORTING - 8 KB)
+
+**Additional CLAUDE.md enhancement recommendations**
+
+Suggested improvements for developer experience in monorepo context.
+
+**Use when**: Reviewing documentation enhancement opportunities
+
+### 6. pr-splitting-strategy.md (STRATEGIC - 12 KB)
+
+**Strategy guide for breaking large PRs into smaller ones**
+
+Contains:
+
+- When to split a large PR (indicators and decision criteria)
+- Strategy for identifying independent commits
+- Step-by-step splitting process
+- Real-world example: How to split PR #2069
+- Benefits, anti-patterns, and decision tree
+- Template for announcing PR splits
+
+**Use when**: Facing complex CI failures in large PRs, planning PR strategy, deciding whether to split
+
+---
+
+## Related Documentation
+
+Outside the analysis directory:
+
+- **PR Splitting Strategy**: `/.claude/docs/pr-splitting-strategy.md` (splitting large PRs)
+- **Main Migration Plan**: `/docs/MONOREPO_MERGER_PLAN.md` (authoritative source)
+- **Path Management Guide**: `/.claude/docs/managing-file-paths.md` (validation procedures)
+- **Build Script Testing**: `/.claude/docs/testing-build-scripts.md` (artifact verification)
+- **CI Monitoring**: `/.claude/docs/master-health-monitoring.md` (CI status checks)
+- **Contributing Guide**: `/CONTRIBUTING.md` (developer instructions)
+
+---
+
+## Quick Navigation
+
+### I Need To...
+
+**Fix current CI failures**
+→ Read: CI_FAILURES_2024-11-21.md (MOST URGENT)
+
+**Decide whether to split a large PR**
+→ Read: pr-splitting-strategy.md (for complex PRs with multiple failures)
+
+**Understand the current state**
+→ Read: Executive Summary in MONOREPO_MIGRATION_ANALYSIS.md
+
+**Plan Phase 3 or 4 work**
+→ Read: "Recommendations for Next Steps" in MONOREPO_MIGRATION_ANALYSIS.md
+
+**Find path references to update**
+→ Read: "Build Scripts - Path Reference Guide" in MIGRATION_QUICK_REFERENCE.md
+
+**Check what's working/broken**
+→ Read: "What's Working Well" and "Critical Issues" in MONOREPO_MIGRATION_ANALYSIS.md
+
+**Run tests before committing**
+→ Read: "Testing Checklist Before Merging" in MIGRATION_QUICK_REFERENCE.md
+
+**Fix a specific issue**
+→ Read: "Common Issues & Solutions" in MIGRATION_QUICK_REFERENCE.md
+
+**Monitor file changes**
+→ Read: "Key Files to Monitor" in MONOREPO_MIGRATION_ANALYSIS.md
+
+**Setup workspace development**
+→ Read: CLAUDE_MD_UPDATES.md and claude-md-improvements.md
+
+## Key Facts at a Glance
+
+**Current Phase**: Phase 5 (Pro Node Renderer Package) - COMPLETE
+**Next Phase**: Phase 6 (Documentation & Polish)
+**Estimated Timeline**: Phases 1-5 complete, Phases 6-7 remaining
+
+**Directory Structures**:
+
+- Surabaya-v1: `packages/` workspaces (fully implemented)
+- Three packages: react-on-rails, react-on-rails-pro, react-on-rails-pro-node-renderer
+
+**Critical Risk**: Path validation for yalc publish
+
+- Past incident: 7-week silent failure (Sept 2024)
+- Prevention: Always test `yarn run yalc.publish` manually
+
+**Packages in Migration**:
+
+- 2 Ruby gems (core + pro)
+- 3 NPM packages (core + pro + pro-node-renderer)
+
+## Document Features
+
+### Color Coding in Quick Reference
+
+- ✅ Working/Complete items
+- ❌ Items needing updates
+- 🔄 In-progress items
+- ⏳ Planned items
+- ⚠️ Critical issues
+
+### Sections in Analysis
+
+- 📋 Executive summaries
+- 🏗️ Architecture details
+- ⚙️ Configuration specifics
+- 📊 Status and metrics
+- 🔍 Issues and risks
+- 📝 Recommendations
+- ✓ Checklists and criteria
+
+## Related Documentation
+
+Outside this analysis directory:
+
+- **Main Migration Plan**: `/docs/MONOREPO_MERGER_PLAN.md` (authoritative source)
+- **Path Management Guide**: `/managing-file-paths.md` (validation procedures)
+- **Build Script Testing**: `/testing-build-scripts.md` (artifact verification)
+- **CI Monitoring**: `/master-health-monitoring.md` (CI status checks)
+- **Contributing Guide**: `/CONTRIBUTING.md` (developer instructions)
+
+## Workflow Tips
+
+### Before Starting Work
+
+1. Read MIGRATION_QUICK_REFERENCE.md phase status
+2. Check "What Needs Attention" section
+3. Review relevant next steps
+
+### During Development
+
+1. Keep MIGRATION_QUICK_REFERENCE.md open for reference
+2. Use path reference guide when modifying configs
+3. Follow testing checklists before committing
+
+### Before Committing
+
+1. Verify all paths in MIGRATION_QUICK_REFERENCE.md
+2. Run testing checklist
+3. Validate build artifacts
+
+### Before Merging PR
+
+1. Confirm all tests pass
+2. Manual verification of yalc publish
+3. Documentation updates aligned
+
+## Contact & Updates
+
+These documents were generated on: 2025-11-19
+
+Updates to analysis:
+
+- Document updates based on phase completion
+- New issues/findings during implementation
+- Success criteria validation
+
+## Completed Phases
+
+**Phase 3**: ✅ Pre-Monorepo Structure Preparation (Completed)
+
+- Validated surabaya-v1 state
+- Updated all paths
+- Tested workspace commands
+
+**Phase 4**: ✅ Final Monorepo Restructuring (Completed)
+
+- Consolidated Pro package
+- Merged CI systems
+- Updated publishing process
+
+**Phase 5**: 🔴 Pro Node Renderer Package Extraction (IN PROGRESS - PR #2069 - CI FAILING)
+
+- ✅ Extracted node-renderer as separate workspace package
+- ✅ Updated build and publishing workflows
+- ❌ CI/CD integration BROKEN - 3 test failures + 1 hung test
+- **Status**: NOT READY TO MERGE - See CI_FAILURES_2024-11-21.md
+
+## Future Phases
+
+**Phase 6**: ⏳ Documentation & Polish (Planned)
+
+- Documentation consolidation
+- Developer experience improvements
+- Final polish and refinements
+
+**Phase 7**: ⏳ Post-Migration Cleanup & Deprecation (Planned)
+
+- Legacy structure removal
+- Deprecation notices
+- Migration guide finalization
+
+---
+
+Last Updated: 2025-11-21
+Status: Phase 5 IN PROGRESS - CI Failures Must Be Fixed Before Merge
+**BLOCKER**: See CI_FAILURES_2024-11-21.md for complete failure analysis