Revert buildConsoleReplay parameter order to match master

Reverted the parameter order changes from the ill-conceived PR #2097.
The correct/original parameter order is:
- customConsoleHistory first (most common usage pattern)
- numberOfMessagesToSkip second (rarely used)

This matches what's currently in master and provides better API ergonomics.

Updated:
- buildConsoleReplay.ts: Restored original parameter order
- serverRenderReactComponent.ts: Updated call sites
- buildConsoleReplay.test.js: Updated test calls

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justin808

packages/react-on-rails/src/buildConsoleReplay.ts

@@ -16,8 +16,8 @@ declare global {
  * @internal Exported for tests and for Ruby helper to wrap with nonce
  */
 export function consoleReplay(
-  numberOfMessagesToSkip = 0,
   customConsoleHistory: (typeof console)['history'] | undefined = undefined,
+  numberOfMessagesToSkip: number = 0,
 ): string {
   // console.history is a global polyfill used in server rendering.
   const consoleHistory = customConsoleHistory ?? console.history;
@@ -55,11 +55,11 @@ export function consoleReplay(
 }
 
 export default function buildConsoleReplay(
-  numberOfMessagesToSkip = 0,
   customConsoleHistory: (typeof console)['history'] | undefined = undefined,
+  numberOfMessagesToSkip: number = 0,
   nonce: string | undefined = undefined,
 ): string {
-  const consoleReplayJS = consoleReplay(numberOfMessagesToSkip, customConsoleHistory);
+  const consoleReplayJS = consoleReplay(customConsoleHistory, numberOfMessagesToSkip);
   if (consoleReplayJS.length === 0) {
     return '';
   }

packages/react-on-rails/src/serverRenderReactComponent.ts

@@ -109,11 +109,11 @@ async function createPromiseResult(
   const consoleHistory = console.history;
   try {
     const html = await renderState.result;
-    const consoleReplayScript = buildConsoleReplay(0, consoleHistory);
+    const consoleReplayScript = buildConsoleReplay(consoleHistory);
     return createResultObject(html, consoleReplayScript, renderState);
   } catch (e: unknown) {
     const errorRenderState = handleRenderingError(e, { componentName, throwJsErrors });
-    const consoleReplayScript = buildConsoleReplay(0, consoleHistory);
+    const consoleReplayScript = buildConsoleReplay(consoleHistory);
     return createResultObject(errorRenderState.result, consoleReplayScript, errorRenderState);
   }
 }

packages/react-on-rails/tests/buildConsoleReplay.test.js

@@ -78,7 +78,7 @@ console.warn.apply(console, ["other message","{\\"c\\":3,\\"d\\":4}"]);
 
   it('buildConsoleReplay adds nonce attribute when provided', () => {
     console.history = [{ arguments: ['test message'], level: 'log' }];
-    const actual = buildConsoleReplay(0, undefined, 'abc123');
+    const actual = buildConsoleReplay(undefined, 0, 'abc123');
 
     expect(actual).toContain('nonce="abc123"');
     expect(actual).toContain('<script id="consoleReplayLog" nonce="abc123">');
@@ -87,7 +87,7 @@ console.warn.apply(console, ["other message","{\\"c\\":3,\\"d\\":4}"]);
 
   it('buildConsoleReplay returns empty string when no console messages', () => {
     console.history = [];
-    const actual = buildConsoleReplay(0, undefined, 'abc123');
+    const actual = buildConsoleReplay(undefined, 0, 'abc123');
 
     expect(actual).toEqual('');
   });
@@ -112,7 +112,7 @@ console.warn.apply(console, ["other message","{\\"c\\":3,\\"d\\":4}"]);
     console.history = [{ arguments: ['test'], level: 'log' }];
     // Attempt attribute injection attack
     const maliciousNonce = 'abc123" onload="alert(1)';
-    const actual = buildConsoleReplay(0, undefined, maliciousNonce);
+    const actual = buildConsoleReplay(undefined, 0, maliciousNonce);
 
     // Should strip dangerous characters (quotes, parens, spaces)
     // = is kept as it's valid in base64, but the quotes are stripped making it harmless